Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1315503002: Revert of Parse arrow functions at proper precedence level (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
CC:
v8-dev, aperez, Michael Starzinger, Yang, Michael Hablich, vogelheim
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Parse arrow functions at proper precedence level (patchset #2 id:60001 of https://codereview.chromium.org/1286383005/ ) Reason for revert: Breaks layout test. Please change test expectation on blink first. --- /mnt/data/b/build/slave/V8-Blink_Linux_64/build/layout-test-results/inspector/sources/debugger-pause/debugger-pause-in-internal-expected.txt +++ /mnt/data/b/build/slave/V8-Blink_Linux_64/build/layout-test-results/inspector/sources/debugger-pause/debugger-pause-in-internal-actual.txt @@ -1,4 +1,4 @@ -CONSOLE ERROR: line 9: Uncaught SyntaxError: Expected () to start arrow function, but got '}' instead of '=>' +CONSOLE ERROR: line 9: Uncaught SyntaxError: Unexpected token ) Tests that pause on exception in internal script does not crash. Script source was shown. Original issue's description: > Parse arrow functions at proper precedence level > > BUG=v8:4211 > LOG=Y > R=rossberg@chromium.org > > Committed: https://crrev.com/9271b0ccf9ddb217deb1f0b9ef9b59b64dc40214 > Cr-Commit-Position: refs/heads/master@{#30298} TBR=rossberg@chromium.org,mstarzinger@chromium.org,fennyfanny655@gmail.com,machenbach@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4211 Committed: https://crrev.com/cc97e524a151c44746d4c569a828373a282797b2 Cr-Commit-Position: refs/heads/master@{#30318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -118 lines) Patch
M src/ast.h View 3 chunks +1 line, -17 lines 0 comments Download
M src/ast-literal-reindexer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parser.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pattern-rewriter.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/preparser.h View 3 chunks +28 lines, -27 lines 0 comments Download
M src/prettyprinter.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M src/typing.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/message/arrow-missing.out View 1 chunk +3 lines, -3 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-4211.js View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Parse arrow functions at proper precedence level
5 years, 4 months ago (2015-08-24 06:56:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315503002/1
5 years, 4 months ago (2015-08-24 06:56:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 06:57:01 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 06:57:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc97e524a151c44746d4c569a828373a282797b2
Cr-Commit-Position: refs/heads/master@{#30318}

Powered by Google App Engine
This is Rietveld 408576698