Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1315483004: [es6] Implement destructuring for `catch` (Closed)

Created:
5 years, 3 months ago by rossberg
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Implement destructuring for `catch` WIP BUG=v8:811 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -15 lines) Patch
M src/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 1 chunk +48 lines, -6 lines 0 comments Download
M src/preparser.cc View 3 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
rossberg
Hi Adam, this is as far as I got so far. Please feel free to ...
5 years, 3 months ago (2015-08-26 18:58:00 UTC) #2
adamk
5 years, 3 months ago (2015-08-26 23:25:50 UTC) #3
Thanks. Was able to add a RemoveUnresolved bandaid to fix the strong mode
failures, but what really needs to be done is an overhaul of the way scoping
works for catch to match ES6. Might work on that before tackling destructuring.

Powered by Google App Engine
This is Rietveld 408576698