Issue 1315473003: [chromedriver] Ignore response of Runtime.evaluate(1) if target closed or crashed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1315473003: [chromedriver] Ignore response of Runtime.evaluate(1) if target closed or crashed. (Closed)

Created:
5 years, 4 months ago by samuong

Modified:
5 years, 4 months ago

Reviewers:
stgao

CC:
chromium-reviews, samuong+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[chromedriver] Ignore response of Runtime.evaluate(1) if target closed or crashed. This reduces flakiness that has been seen recently with WindowSwitchingTest.testCanCallGetWindowHandlesAfterClosingAWindow. BUG=524079 TBR=stgao@chromium.org Committed: https://crrev.com/858804b290f68d69a91626cab5136d336f7b0a9a Cr-Commit-Position: refs/heads/master@{#345275}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	chrome/test/chromedriver/chrome/navigation_tracker.cc	View		1 chunk	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315473003/1

5 years, 4 months ago (2015-08-25 06:21:49 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/858804b290f68d69a91626cab5136d336f7b0a9a Cr-Commit-Position: refs/heads/master@{#345275}

5 years, 4 months ago (2015-08-25 06:49:37 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages