Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2099)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315443013: Update OWNERS file now that Chris has left the project. (Closed)

Created:
5 years, 3 months ago by Yaron
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update OWNERS file now that Chris has left the project. TBR=sgurun Committed: https://crrev.com/23eab49ca0ee6393cc4df084ed79201011a19749 Cr-Commit-Position: refs/heads/master@{#348427}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M build/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_distiller/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/OWNERS View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb_proto/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/resources/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/test/data/dom_distiller/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/android_platform/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/android_protobuf/OWNERS View 1 chunk +1 line, -2 lines 3 comments Download
M third_party/dom_distiller_js/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/errorprone/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (5 generated)
Yaron
Updating owners with the following areas agrieve: build ownership mdjones: dom_distiller jdduke: content/public/android/java/src/org/chromium/content/browser/input/ sgurun: android_platform
5 years, 3 months ago (2015-09-08 17:51:04 UTC) #2
Yaron
oops. missed adding a few to R line
5 years, 3 months ago (2015-09-08 17:51:42 UTC) #4
nyquist
lgtm % one comment about meek@ https://codereview.chromium.org/1315443013/diff/1/third_party/android_protobuf/OWNERS File third_party/android_protobuf/OWNERS (right): https://codereview.chromium.org/1315443013/diff/1/third_party/android_protobuf/OWNERS#newcode1 third_party/android_protobuf/OWNERS:1: meek@chromium.org I don't ...
5 years, 3 months ago (2015-09-08 17:55:10 UTC) #5
Yaron
https://codereview.chromium.org/1315443013/diff/1/third_party/android_protobuf/OWNERS File third_party/android_protobuf/OWNERS (right): https://codereview.chromium.org/1315443013/diff/1/third_party/android_protobuf/OWNERS#newcode1 third_party/android_protobuf/OWNERS:1: meek@chromium.org On 2015/09/08 17:55:10, nyquist wrote: > I don't ...
5 years, 3 months ago (2015-09-08 17:58:26 UTC) #6
agrieve
On 2015/09/08 17:58:26, Yaron wrote: > https://codereview.chromium.org/1315443013/diff/1/third_party/android_protobuf/OWNERS > File third_party/android_protobuf/OWNERS (right): > > https://codereview.chromium.org/1315443013/diff/1/third_party/android_protobuf/OWNERS#newcode1 > ...
5 years, 3 months ago (2015-09-08 18:01:12 UTC) #7
jdduke (slow)
content/ lgtm
5 years, 3 months ago (2015-09-08 18:45:21 UTC) #8
nyquist
still lgtm https://codereview.chromium.org/1315443013/diff/1/third_party/android_protobuf/OWNERS File third_party/android_protobuf/OWNERS (right): https://codereview.chromium.org/1315443013/diff/1/third_party/android_protobuf/OWNERS#newcode1 third_party/android_protobuf/OWNERS:1: meek@chromium.org On 2015/09/08 17:58:26, Yaron wrote: > ...
5 years, 3 months ago (2015-09-08 19:08:25 UTC) #9
mdjones
lgtm
5 years, 3 months ago (2015-09-08 21:06:57 UTC) #10
nyquist
Since sgurun will be out for some time, could we maybe just TBR him instead?
5 years, 3 months ago (2015-09-11 15:37:49 UTC) #11
Yaron
On 2015/09/11 15:37:49, nyquist wrote: > Since sgurun will be out for some time, could ...
5 years, 3 months ago (2015-09-11 16:05:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315443013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315443013/1
5 years, 3 months ago (2015-09-11 16:06:03 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105966)
5 years, 3 months ago (2015-09-11 17:20:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315443013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315443013/1
5 years, 3 months ago (2015-09-11 17:22:14 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 17:59:24 UTC) #19
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/23eab49ca0ee6393cc4df084ed79201011a19749 Cr-Commit-Position: refs/heads/master@{#348427}
5 years, 3 months ago (2015-09-11 17:59:50 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:23:49 UTC) #21
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/23eab49ca0ee6393cc4df084ed79201011a19749
Cr-Commit-Position: refs/heads/master@{#348427}

Powered by Google App Engine
This is Rietveld 408576698