Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1315443010: Oilpan: Re-add a GC_PROFILING macro to GCInfo::className() (Closed)

Created:
5 years, 3 months ago by haraken
Modified:
5 years, 3 months ago
Reviewers:
sof
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Re-add a GC_PROFILING macro to GCInfo::className() This is a partial revert of r201891 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201906

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/platform/heap/GCInfo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/heap/Visitor.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
haraken
PTAL
5 years, 3 months ago (2015-09-08 06:26:16 UTC) #2
sof
You also need to expose TypenameStringTrait<> with GC_PROFILING.
5 years, 3 months ago (2015-09-08 06:49:13 UTC) #3
haraken
On 2015/09/08 06:49:13, sof wrote: > You also need to expose TypenameStringTrait<> with GC_PROFILING. Done.
5 years, 3 months ago (2015-09-08 06:54:09 UTC) #4
sof
lgtm (locally verified.)
5 years, 3 months ago (2015-09-08 07:25:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315443010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315443010/20001
5 years, 3 months ago (2015-09-08 07:29:59 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 10:00:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201906

Powered by Google App Engine
This is Rietveld 408576698