Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1315443007: bluetooth: Explain why standard names aren't recognized in error message. (Closed)

Created:
5 years, 4 months ago by scheib
Modified:
5 years, 3 months ago
Reviewers:
ortuno
CC:
blink-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Explain why standard names aren't recognized in error message. Developers are expressing confusion when passing invalid service names, sometimes because they pass an invalid UUID that nearly looks correct. Explain more explicitly in the error message what is accepted. BUG=491441 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201234

Patch Set 1 #

Patch Set 2 : Improved error message based on ortuno comment #

Patch Set 3 : merge TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M LayoutTests/bluetooth/getCharacteristic.html View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M LayoutTests/bluetooth/getPrimaryService.html View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothUUID.cpp View 1 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
scheib
5 years, 4 months ago (2015-08-25 22:11:30 UTC) #2
scheib
improved message.
5 years, 4 months ago (2015-08-25 22:56:57 UTC) #3
ortuno
lgtm
5 years, 3 months ago (2015-08-26 16:07:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315443007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315443007/40001
5 years, 3 months ago (2015-08-26 16:53:08 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 16:57:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201234

Powered by Google App Engine
This is Rietveld 408576698