Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: content/browser/appcache/appcache_response.h

Issue 1315443003: ServiceWorkerWriteToCacheJob: refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_cache_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_response.h
diff --git a/content/browser/appcache/appcache_response.h b/content/browser/appcache/appcache_response.h
index 8d6c79060bdcf2eb76ac5c4870d90fcdc36e089d..a4c87db3d562ac7b97b6ffa9ae53a35743b277c5 100644
--- a/content/browser/appcache/appcache_response.h
+++ b/content/browser/appcache/appcache_response.h
@@ -209,8 +209,9 @@ class CONTENT_EXPORT AppCacheResponseWriter
// negative error code or the number of bytes written. The 'callback' is a
// required parameter. The contents of 'info_buf' are not modified.
// Should only be called where there is no Write operation in progress.
- void WriteInfo(HttpResponseInfoIOBuffer* info_buf,
- const net::CompletionCallback& callback);
+ // (virtual for testing)
+ virtual void WriteInfo(HttpResponseInfoIOBuffer* info_buf,
+ const net::CompletionCallback& callback);
// Writes data to storage. Always returns the result of the write
// asynchronously through the 'callback'. Returns the number of bytes written
@@ -220,8 +221,10 @@ class CONTENT_EXPORT AppCacheResponseWriter
// the number of bytes written. The 'callback' is a required parameter.
// The contents of 'buf' are not modified.
// Should only be called where there is no Write operation in progress.
- void WriteData(net::IOBuffer* buf, int buf_len,
- const net::CompletionCallback& callback);
+ // (virtual for testing)
+ virtual void WriteData(net::IOBuffer* buf,
+ int buf_len,
+ const net::CompletionCallback& callback);
// Returns true if there is a write pending.
bool IsWritePending() { return IsIOPending(); }
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_cache_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698