ServiceWorkerWriteToCacheJob: refactor

content/browser/service_worker/service_worker_disk_cache.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DISK_CACHE_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DISK_CACHE_H_
 
 #include "content/browser/appcache/appcache_disk_cache.h"
 #include "content/common/content_export.h"
 
@@ skipping 14 matching lines @@
  private:
   friend class ServiceWorkerDiskCacheMigrator;
   friend class ServiceWorkerDiskCacheMigratorTest;
   explicit ServiceWorkerDiskCache(bool use_simple_cache);
 };
 
 class CONTENT_EXPORT ServiceWorkerResponseReader
     : public AppCacheResponseReader {
  protected:
   // Should only be constructed by the storage class.
+  friend class MockServiceWorkerResponseReader;
   friend class ServiceWorkerDiskCacheMigrator;
   friend class ServiceWorkerDiskCacheMigratorTest;
   friend class ServiceWorkerStorage;
   ServiceWorkerResponseReader(
       int64 response_id,
       ServiceWorkerDiskCache* disk_cache);
 };
 
 class CONTENT_EXPORT ServiceWorkerResponseWriter
     : public AppCacheResponseWriter {
  protected:
   // Should only be constructed by the storage class.
+  friend class MockServiceWorkerResponseWriter;

[Randy Smith (Not in Mondays), 2015/09/13 21:32:07]

I'm confused.  What are the friend decls for?  There doesn't seem to be anything
private about this class that the friend decl gives "Mock*" access to.

[Elly Fong-Jones, 2015/09/15 15:08:24]

These are left over from earlier. Deleted.

   friend class ServiceWorkerDiskCacheMigrator;
   friend class ServiceWorkerDiskCacheMigratorTest;
   friend class ServiceWorkerStorage;
   ServiceWorkerResponseWriter(
       int64 response_id,
       ServiceWorkerDiskCache* disk_cache);
 };
 
 class CONTENT_EXPORT ServiceWorkerResponseMetadataWriter
     : public AppCacheResponseMetadataWriter {
  protected:
   // Should only be constructed by the storage class.
   friend class ServiceWorkerDiskCacheMigrator;
   friend class ServiceWorkerDiskCacheMigratorTest;
   friend class ServiceWorkerStorage;
   ServiceWorkerResponseMetadataWriter(int64 response_id,
                                       ServiceWorkerDiskCache* disk_cache);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DISK_CACHE_H_