ServiceWorkerWriteToCacheJob: refactor

content/browser/appcache/appcache_response.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_RESPONSE_H_
 #define CONTENT_BROWSER_APPCACHE_APPCACHE_RESPONSE_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 190 matching lines @@
     : public AppCacheResponseIO {
  public:
   ~AppCacheResponseWriter() override;
 
   // Writes the http info to storage. Always returns the result of the write
   // asynchronously through the 'callback'. Returns the number of bytes written
   // or a net:: error code. The writer acquires a reference to the 'info_buf'
   // until completion at which time the callback is invoked with either a
   // negative error code or the number of bytes written. The 'callback' is a
   // required parameter. The contents of 'info_buf' are not modified.
   // Should only be called where there is no Write operation in progress.

[michaeln, 2015/09/10 20:50:27]

please put a comment here that says
// (virtual for testing)
similar to those on ReadInfo and ReadData

-  void WriteInfo(HttpResponseInfoIOBuffer* info_buf,
-                 const net::CompletionCallback& callback);
+  virtual void WriteInfo(HttpResponseInfoIOBuffer* info_buf,
+                         const net::CompletionCallback& callback);
 
   // Writes data to storage. Always returns the result of the write
   // asynchronously through the 'callback'. Returns the number of bytes written
   // or a net:: error code. Guaranteed to not perform partial writes.
   // The writer acquires a reference to the provided 'buf' until completion at
   // which time the callback is invoked with either a negative error code or
   // the number of bytes written. The 'callback' is a required parameter.
   // The contents of 'buf' are not modified.
   // Should only be called where there is no Write operation in progress.
-  void WriteData(net::IOBuffer* buf, int buf_len,
-                 const net::CompletionCallback& callback);
+  virtual void WriteData(net::IOBuffer* buf,
+                         int buf_len,
+                         const net::CompletionCallback& callback);
 
   // Returns true if there is a write pending.
   bool IsWritePending() { return IsIOPending(); }
 
   // Returns the amount written, info and data.
   int64 amount_written() { return info_size_ + write_position_; }
 
  protected:
   // Should only be constructed by the storage class and derivatives.
   AppCacheResponseWriter(int64 response_id,
@@ skipping 62 matching lines @@
   void OnIOComplete(int result) override;
   void OnOpenEntryComplete() override;
 
   int write_amount_;
   base::WeakPtrFactory<AppCacheResponseMetadataWriter> weak_factory_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_APPCACHE_APPCACHE_RESPONSE_H_