Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Side by Side Diff: Source/core/rendering/CompositedLayerMapping.cpp

Issue 131543013: Update scroll parent correctly for squashing layers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 843 matching lines...) Expand 10 before | Expand all | Expand 10 after
854 } 854 }
855 855
856 updateContentsRect(isSimpleContainer); 856 updateContentsRect(isSimpleContainer);
857 updateBackgroundColor(isSimpleContainer); 857 updateBackgroundColor(isSimpleContainer);
858 updateDrawsContent(isSimpleContainer); 858 updateDrawsContent(isSimpleContainer);
859 updateContentsOpaque(); 859 updateContentsOpaque();
860 updateAfterWidgetResize(); 860 updateAfterWidgetResize();
861 updateRenderingContext(); 861 updateRenderingContext();
862 updateShouldFlattenTransform(); 862 updateShouldFlattenTransform();
863 updateChildrenTransform(); 863 updateChildrenTransform();
864 updateScrollParent(m_owningLayer->scrollParent());
864 registerScrollingLayers(); 865 registerScrollingLayers();
865 866
866 updateCompositingReasons(); 867 updateCompositingReasons();
867 } 868 }
868 869
869 void CompositedLayerMapping::registerScrollingLayers() 870 void CompositedLayerMapping::registerScrollingLayers()
870 { 871 {
871 // Register fixed position layers and their containers with the scrolling co ordinator. 872 // Register fixed position layers and their containers with the scrolling co ordinator.
872 ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLayer(m _owningLayer); 873 ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLayer(m _owningLayer);
873 if (!scrollingCoordinator) 874 if (!scrollingCoordinator)
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
1357 if (layer != topmostLayer) 1358 if (layer != topmostLayer)
1358 scrollParent = 0; 1359 scrollParent = 0;
1359 1360
1360 scrollingCoordinator->updateScrollParentForGraphicsLayer(layer, scrollParent ); 1361 scrollingCoordinator->updateScrollParentForGraphicsLayer(layer, scrollParent );
1361 } 1362 }
1362 1363
1363 void CompositedLayerMapping::updateScrollParent(RenderLayer* scrollParent) 1364 void CompositedLayerMapping::updateScrollParent(RenderLayer* scrollParent)
1364 { 1365 {
1365 1366
1366 if (ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLay er(m_owningLayer)) { 1367 if (ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLay er(m_owningLayer)) {
1367 GraphicsLayer* topmostLayer = localRootForOwningLayer(); 1368 GraphicsLayer* topmostLayer = childForSuperlayers();
1369 updateScrollParentForGraphicsLayer(m_squashingContainmentLayer.get(), to pmostLayer, scrollParent, scrollingCoordinator);
1368 updateScrollParentForGraphicsLayer(m_ancestorClippingLayer.get(), topmos tLayer, scrollParent, scrollingCoordinator); 1370 updateScrollParentForGraphicsLayer(m_ancestorClippingLayer.get(), topmos tLayer, scrollParent, scrollingCoordinator);
1369 updateScrollParentForGraphicsLayer(m_graphicsLayer.get(), topmostLayer, scrollParent, scrollingCoordinator); 1371 updateScrollParentForGraphicsLayer(m_graphicsLayer.get(), topmostLayer, scrollParent, scrollingCoordinator);
1370 } 1372 }
1371 } 1373 }
1372 1374
1373 void CompositedLayerMapping::updateClipParent(RenderLayer* clipParent) 1375 void CompositedLayerMapping::updateClipParent(RenderLayer* clipParent)
1374 { 1376 {
1375 if (ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLay er(m_owningLayer)) 1377 if (ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLay er(m_owningLayer))
1376 scrollingCoordinator->updateClipParentForGraphicsLayer(m_graphicsLayer.g et(), clipParent); 1378 scrollingCoordinator->updateClipParentForGraphicsLayer(m_graphicsLayer.g et(), clipParent);
1377 } 1379 }
(...skipping 882 matching lines...) Expand 10 before | Expand all | Expand 10 after
2260 } else if (graphicsLayer == m_scrollingContentsLayer.get()) { 2262 } else if (graphicsLayer == m_scrollingContentsLayer.get()) {
2261 name = "Scrolling Contents Layer"; 2263 name = "Scrolling Contents Layer";
2262 } else { 2264 } else {
2263 ASSERT_NOT_REACHED(); 2265 ASSERT_NOT_REACHED();
2264 } 2266 }
2265 2267
2266 return name; 2268 return name;
2267 } 2269 }
2268 2270
2269 } // namespace WebCore 2271 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/platform/graphics/CompositingReasons.h » ('j') | Source/platform/graphics/CompositingReasons.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698