Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: trunk/src/ash/wm/drag_window_resizer_unittest.cc

Issue 131543006: Revert 243986 "Fix AdjustBoundsToEnsureWindowVisibility to work ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ash/wm/drag_window_resizer.cc ('k') | trunk/src/ash/wm/system_gesture_event_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ash/wm/drag_window_resizer_unittest.cc
===================================================================
--- trunk/src/ash/wm/drag_window_resizer_unittest.cc (revision 244019)
+++ trunk/src/ash/wm/drag_window_resizer_unittest.cc (working copy)
@@ -244,9 +244,12 @@
gfx::Rect intersect(window_->GetRootWindow()->GetBoundsInScreen());
intersect.Intersect(window_bounds_in_screen);
- EXPECT_LE(10, intersect.width());
- EXPECT_LE(10, intersect.height());
- EXPECT_TRUE(window_bounds_in_screen.Contains(gfx::Point(800, 10)));
+ // TODO(oshima): Following condition fails without docked window resizer.
+ // Proper fix caused the other failures, so I'm disabling these
+ // for m33 (Which is harmless).
+ // EXPECT_LE(10, intersect.width());
+ // EXPECT_LE(10, intersect.height());
+ // EXPECT_TRUE(window_bounds_in_screen.Contains(gfx::Point(800, 10)));
}
// Dropping a window that is larger than the destination work area
@@ -513,11 +516,6 @@
// Move window from the root window with 2.0 device scale factor to the root
// window with 1.0 device scale factor.
{
- // Make sure the window is on the default container first.
- aura::Window* default_container =
- GetRootWindowController(root_windows[1])->GetContainer(
- internal::kShellWindowId_DefaultContainer);
- default_container->AddChild(window_.get());
window_->SetBoundsInScreen(
gfx::Rect(600, 0, 50, 60),
Shell::GetScreen()->GetDisplayNearestWindow(root_windows[1]));
« no previous file with comments | « trunk/src/ash/wm/drag_window_resizer.cc ('k') | trunk/src/ash/wm/system_gesture_event_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698