Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: Source/core/layout/PendingSelection.h

Issue 1315423006: Moves an implementation of LayoutView::commitPendingSelection() to PendingSelection::commit() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-07T11:06:22 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutView.cpp ('k') | Source/core/layout/PendingSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/PendingSelection.h
diff --git a/Source/core/layout/PendingSelection.h b/Source/core/layout/PendingSelection.h
index 18b7ee757a0bbcdc521cb7cf4142549c7d3f79bd..c9564583607226ace62ee618ecdb78db430a4ab0 100644
--- a/Source/core/layout/PendingSelection.h
+++ b/Source/core/layout/PendingSelection.h
@@ -30,6 +30,7 @@ namespace blink {
class Document;
class FrameSelection;
+class LayoutView;
class PendingSelection final : public NoBaseWillBeGarbageCollected<PendingSelection> {
WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(PendingSelection);
@@ -41,10 +42,7 @@ public:
bool hasPendingSelection() const { return m_hasPendingSelection; }
void setSelection(const FrameSelection&);
- void clear();
-
- bool isInDocument(const Document&) const;
- VisibleSelection calcVisibleSelection() const;
+ void commit(LayoutView&);
DECLARE_TRACE();
@@ -56,6 +54,10 @@ private:
template <typename Strategy>
VisibleSelection calcVisibleSelectionAlgorithm() const;
+ void clear();
+ template <typename Strategy>
+ void commitAlgorithm(LayoutView&);
+ bool isInDocument(const Document&) const;
VisibleSelection m_selection;
bool m_hasPendingSelection : 1;
« no previous file with comments | « Source/core/layout/LayoutView.cpp ('k') | Source/core/layout/PendingSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698