Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1315423006: Moves an implementation of LayoutView::commitPendingSelection() to PendingSelection::commit() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, yoichio, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Moves an implementation of LayoutView::commitPendingSelection() to PendingSelection::commit() This patch moves an implementation of |LayoutView::commitPendingSelection()| to |PendingSelection::commit()| as a preparation of moving it to "editing/", for reducing exposing editing functions to layout layer. Following patch will move |PendingSelection| to "editing/". This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201854

Patch Set 1 : 2015-09-07T11:06:22 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -64 lines) Patch
M Source/core/layout/LayoutView.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -53 lines 0 comments Download
M Source/core/layout/PendingSelection.h View 3 chunks +6 lines, -4 lines 0 comments Download
M Source/core/layout/PendingSelection.cpp View 2 chunks +59 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-07 03:25:45 UTC) #2
tkent
lgtm
5 years, 3 months ago (2015-09-07 03:57:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315423006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315423006/1
5 years, 3 months ago (2015-09-07 04:15:34 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 04:19:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201854

Powered by Google App Engine
This is Rietveld 408576698