Source/platform/ScriptForbiddenScope.h - Issue 1315413005: Fix assertion failure in ScriptRegexp::match

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/ScriptForbiddenScope.h

Issue 1315413005: Fix assertion failure in ScriptRegexp::match (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed haraken's comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/ScriptForbiddenScope.h

diff --git a/Source/platform/ScriptForbiddenScope.h b/Source/platform/ScriptForbiddenScope.h

index a68fdceaf0179411614e1a8964ce03848cb41845..9c3ba7e8f5dda74bb6ab5445c065f6fecf9b7b77 100644

--- a/Source/platform/ScriptForbiddenScope.h

+++ b/Source/platform/ScriptForbiddenScope.h

@@ -7,6 +7,7 @@

#include "platform/PlatformExport.h"

#include "wtf/Assertions.h"

+#include "wtf/Optional.h"

#include "wtf/TemporaryChange.h"

namespace blink {

@@ -21,7 +22,7 @@ public:

AllowUserAgentScript();

~AllowUserAgentScript();

private:

- TemporaryChange<unsigned> m_change;

+ Optional<TemporaryChange<unsigned>> m_change;

};

static void enter();