Chromium Code Reviews| Index: LayoutTests/fast/mediastream/RTCPeerConnection.html |
| diff --git a/LayoutTests/fast/mediastream/RTCPeerConnection.html b/LayoutTests/fast/mediastream/RTCPeerConnection.html |
| index 74e2e4c89dca2fbb2d3bb65476f52a73c370abfc..6628200fd612a5db400619d9534cb5f7a32a8307 100644 |
| --- a/LayoutTests/fast/mediastream/RTCPeerConnection.html |
| +++ b/LayoutTests/fast/mediastream/RTCPeerConnection.html |
| @@ -21,8 +21,12 @@ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', cr |
| shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, null);"); |
| shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, null);"); |
| shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo.com']}]}, null);"); |
| +shouldNotThrow("new webkitRTCPeerConnection({fooServers:[], iceServers:[{urls:['stun:foo.com', 'turn:foo.com']}]}, null);"); |
|
pthatcher2
2015/09/16 04:09:58
Why bother having fooServers?
guoweis_left_chromium
2015/09/16 17:29:05
There are existing tests using "fooServers" which
|
| +shouldNotThrow("new webkitRTCPeerConnection({iceServers:undefined}, null);"); |
| +shouldNotThrow("new webkitRTCPeerConnection({}, null);"); |
| +shouldThrow("new webkitRTCPeerConnection({iceServers:null}, null);"); |
| -shouldThrow("new webkitRTCPeerConnection({fooServers:[]}, null);"); |
| +shouldNotThrow("new webkitRTCPeerConnection({fooServers:[]}, null);"); |
|
pthatcher2
2015/09/16 04:09:58
What does this test buy us over {}? In other word
guoweis_left_chromium
2015/09/16 17:29:05
Done.
|
| shouldThrow("new webkitRTCPeerConnection({iceServers:true}, null);"); |
| shouldThrow("new webkitRTCPeerConnection({iceServers:[1, 2, 3]}, null);"); |
| shouldThrow("new webkitRTCPeerConnection({iceServers:[{}]}, null);"); |