 Chromium Code Reviews
 Chromium Code Reviews Issue 1315413004:
  Enable generation of local host candidate.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 1315413004:
  Enable generation of local host candidate.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * Copyright (C) 2012 Google Inc. All rights reserved. | 2 * Copyright (C) 2012 Google Inc. All rights reserved. | 
| 3 * | 3 * | 
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without | 
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions | 
| 6 * are met: | 6 * are met: | 
| 7 * | 7 * | 
| 8 * 1. Redistributions of source code must retain the above copyright | 8 * 1. Redistributions of source code must retain the above copyright | 
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. | 
| 10 * 2. Redistributions in binary form must reproduce the above copyright | 10 * 2. Redistributions in binary form must reproduce the above copyright | 
| (...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 88 | 88 | 
| 89 void appendServer(RTCIceServer* server) { m_servers.append(server); } | 89 void appendServer(RTCIceServer* server) { m_servers.append(server); } | 
| 90 size_t numberOfServers() { return m_servers.size(); } | 90 size_t numberOfServers() { return m_servers.size(); } | 
| 91 RTCIceServer* server(size_t index) { return m_servers[index].get(); } | 91 RTCIceServer* server(size_t index) { return m_servers[index].get(); } | 
| 92 void setIceTransports(RTCIceTransports iceTransports) { m_iceTransports = ic eTransports; } | 92 void setIceTransports(RTCIceTransports iceTransports) { m_iceTransports = ic eTransports; } | 
| 93 RTCIceTransports iceTransports() { return m_iceTransports; } | 93 RTCIceTransports iceTransports() { return m_iceTransports; } | 
| 94 void setBundlePolicy(RTCBundlePolicy bundlePolicy) { m_bundlePolicy = bundle Policy; } | 94 void setBundlePolicy(RTCBundlePolicy bundlePolicy) { m_bundlePolicy = bundle Policy; } | 
| 95 RTCBundlePolicy bundlePolicy() { return m_bundlePolicy; } | 95 RTCBundlePolicy bundlePolicy() { return m_bundlePolicy; } | 
| 96 void setRtcpMuxPolicy(RTCRtcpMuxPolicy rtcpMuxPolicy) { m_rtcpMuxPolicy = rt cpMuxPolicy; } | 96 void setRtcpMuxPolicy(RTCRtcpMuxPolicy rtcpMuxPolicy) { m_rtcpMuxPolicy = rt cpMuxPolicy; } | 
| 97 RTCRtcpMuxPolicy rtcpMuxPolicy() { return m_rtcpMuxPolicy; } | 97 RTCRtcpMuxPolicy rtcpMuxPolicy() { return m_rtcpMuxPolicy; } | 
| 98 bool enableLocalhostCandidate() { return m_enableLocalhostCandidate; } | |
| 99 void setEnableLocalhostCandidate(bool enableLocalhostCandidate) { m_enableLo calhostCandidate = enableLocalhostCandidate; } | |
| 98 | 100 | 
| 99 DEFINE_INLINE_TRACE() { visitor->trace(m_servers); } | 101 DEFINE_INLINE_TRACE() { visitor->trace(m_servers); } | 
| 100 | 102 | 
| 101 private: | 103 private: | 
| 102 RTCConfiguration() : | 104 RTCConfiguration() : | 
| 103 m_iceTransports(RTCIceTransportsAll), | 105 m_iceTransports(RTCIceTransportsAll), | 
| 104 m_bundlePolicy(RTCBundlePolicyBalanced), | 106 m_bundlePolicy(RTCBundlePolicyBalanced), | 
| 105 m_rtcpMuxPolicy(RTCRtcpMuxPolicyNegotiate) { } | 107 m_rtcpMuxPolicy(RTCRtcpMuxPolicyNegotiate), | 
| 108 m_enableLocalhostCandidate(false) { } | |
| 106 | 109 | 
| 107 HeapVector<Member<RTCIceServer>> m_servers; | 110 HeapVector<Member<RTCIceServer>> m_servers; | 
| 
juberti
2015/08/28 00:34:58
Could this be a pointer instead? Then, if undefine
 
guoweis_left_chromium
2015/08/28 04:53:58
since we're not going to expose m_servers public,
 | |
| 108 RTCIceTransports m_iceTransports; | 111 RTCIceTransports m_iceTransports; | 
| 109 RTCBundlePolicy m_bundlePolicy; | 112 RTCBundlePolicy m_bundlePolicy; | 
| 110 RTCRtcpMuxPolicy m_rtcpMuxPolicy; | 113 RTCRtcpMuxPolicy m_rtcpMuxPolicy; | 
| 114 bool m_enableLocalhostCandidate; | |
| 111 }; | 115 }; | 
| 112 | 116 | 
| 113 } // namespace blink | 117 } // namespace blink | 
| 114 | 118 | 
| 115 #endif // RTCConfiguration_h | 119 #endif // RTCConfiguration_h | 
| OLD | NEW |