LayoutTests/fast/block/margin-collapse/table-beside-float-complex-margin-collapsing.html - Issue 1315353005: Avoid duplicated code in LayoutBlockChild::layoutBlockChild().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/block/margin-collapse/table-beside-float-complex-margin-collapsing.html

Issue 1315353005: Avoid duplicated code in LayoutBlockChild::layoutBlockChild(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/block/margin-collapse/bfc-beside-float-complex-margin-collapsing.html ('K') | « LayoutTests/fast/block/margin-collapse/line-beside-float-complex-margin-collapsing-expected.html ('k') | LayoutTests/fast/block/margin-collapse/table-beside-float-complex-margin-collapsing-expected.html » ('j') | Source/core/layout/LayoutBlockFlow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/block/margin-collapse/table-beside-float-complex-margin-collapsing.html

diff --git a/LayoutTests/fast/block/margin-collapse/table-beside-float-complex-margin-collapsing.html b/LayoutTests/fast/block/margin-collapse/table-beside-float-complex-margin-collapsing.html

new file mode 100644

index 0000000000000000000000000000000000000000..3f6b56bb8b343bf460ecc76f9b1f9f521b78f6cc

--- /dev/null

+++ b/LayoutTests/fast/block/margin-collapse/table-beside-float-complex-margin-collapsing.html

@@ -0,0 +1,26 @@

+<!DOCTYPE html>

+<p>Given a float followed by a regular block with the same height as the float, then a block B with

+ a negative margin, followed by a table. Check that the table doesn't overlap with the

+ float. There's an empty collapse-through block before B, so that our initial logical top

+ estimate fails and we have to relayout. When laying out again, we have to detect that the float

+ that we first thought didn't affect the table now affects it.</p>

+<p>The word "PASS" should be seen below, to the right of a blue block.</p>

+<div style="width:20em; color:blue;">

+ <div>

+ <div style="float:left; width:8em; height:8em; margin-right:1em; background:blue;"></div>

+ <div style="height:8em;"></div>

+ <div>

+ <!-- Here's an empty block that we can just collapse through, but we don't realize that

+ when calculating our initial top estimate on its parent, so we have to relayout

+ when it turns out that a negative margin has pulled us upwards (and suddenly we

+ have something block-level that's affected by the float). -->

+ <div></div>

+ <div style="margin-top:-4em;"></div>

+ <!-- Here's a block-level element that is affected by floats, because it's a table. We

+ could have used e.g. an overflow:hidden DIV for the same effect. -->

+ <div style="display:table;">PASS</div>

+ </div>

+</div>