Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1315323007: Switch blink repo to use chromium-status.appspot.com (Closed)

Created:
5 years, 3 months ago by Paweł Hajdan Jr.
Modified:
5 years, 3 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 chunk +1 line, -1 line 0 comments Download
M codereview.settings View 1 chunk +1 line, -1 line 0 comments Download
M infra/config/cq.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Paweł Hajdan Jr.
5 years, 3 months ago (2015-09-04 09:59:27 UTC) #2
Adrian Kuegel
lgtm
5 years, 3 months ago (2015-09-04 10:01:18 UTC) #3
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as 201792 (presubmit successful).
5 years, 3 months ago (2015-09-04 12:32:08 UTC) #4
Paweł Hajdan Jr.
TBR
5 years, 3 months ago (2015-09-04 12:32:19 UTC) #6
Paweł Hajdan Jr.
5 years, 3 months ago (2015-09-04 17:44:24 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1308163009/ by phajdan.jr@chromium.org.

The reason for reverting is: This moves chromium.webkit off blink tab to
chromium tab on sheriff-o-matic, which is undesired
(https://code.google.com/p/chromium/issues/detail?id=528346).

Powered by Google App Engine
This is Rietveld 408576698