Chromium Code Reviews| Index: third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp |
| diff --git a/third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp b/third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp |
| index 950b8fa52052b94119b78c7f5c5a83352e525d71..e63df14281921a80243d9a0d7735b4ef4fa780a2 100644 |
| --- a/third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp |
| +++ b/third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp |
| @@ -83,9 +83,24 @@ bool Extensions3DUtil::isExtensionEnabled(const String& name) |
| bool Extensions3DUtil::canUseCopyTextureCHROMIUM(GLenum destTarget, GLenum destFormat, GLenum destType, GLint level) |
| { |
| - // FIXME: restriction of (RGB || RGBA)/UNSIGNED_BYTE/(Level 0) should be lifted when |
| + switch (destTarget) { |
| + case GL_TEXTURE_2D: |
| + break; |
| + // TODO(dshwang): support cube map. crbug.com/517548 |
|
dshwang
2015/10/21 16:12:16
As https://codereview.chromium.org/1275773003 was
|
| + case GL_TEXTURE_CUBE_MAP_POSITIVE_X: |
| + case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: |
| + case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: |
| + case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: |
| + case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: |
| + case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: |
| + return false; |
| + default: |
| + ASSERT_NOT_REACHED(); |
| + return false; |
| + } |
| + // TODO(dshwang): restriction of (RGB || RGBA)/UNSIGNED_BYTE/(Level 0) should be lifted when |
| // WebGraphicsContext3D::copyTextureCHROMIUM(...) are fully functional. |
| - if (destTarget == GL_TEXTURE_2D && (destFormat == GL_RGB || destFormat == GL_RGBA) |
| + if ((destFormat == GL_RGB || destFormat == GL_RGBA) |
| && destType == GL_UNSIGNED_BYTE |
| && !level) |
| return true; |