webgl: optimize webgl.texSubImage2D(video) path.

content/renderer/media/android/webmediaplayer_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
 
 #include <jni.h>
 #include <string>
 #include <vector>
@@ skipping 117 matching lines @@
   // Methods for painting.
   // FIXME: This path "only works" on Android. It is a workaround for the
   // issue that Skia could not handle Android's GL_TEXTURE_EXTERNAL_OES texture
   // internally. It should be removed and replaced by the normal paint path.
   // https://code.google.com/p/skia/issues/detail?id=1189
   virtual void paint(blink::WebCanvas* canvas,
                      const blink::WebRect& rect,
                      unsigned char alpha,
                      SkXfermode::Mode mode);
 
-  bool copyVideoTextureToPlatformTexture(
+  // TODO(dshwang): remove it. virtual trick allows to remove it in blink.
+  // crbug.com/504773
+  virtual bool copyVideoTextureToPlatformTexture(
       blink::WebGraphicsContext3D* web_graphics_context,
       unsigned int texture,
       unsigned int internal_format,
       unsigned int type,
       bool premultiply_alpha,
+      bool flip_y);
+
+  bool copyVideoTextureToPlatformTexture(
+      blink::WebGraphicsContext3D* web_graphics_context,
+      unsigned int target,
+      unsigned int texture,
+      unsigned int internal_format,
+      unsigned int type,
+      int level,
+      bool premultiply_alpha,
+      bool flip_y) override;
+  bool copyVideoSubTextureToPlatformTexture(

[oetuaho-nv, 2015/10/01 07:46:21]

I think that it needs to be clearer that this is copying the whole video to a
subregion of the target texture. Based on the function name it might as well be
copying a subregion of the video.

I'd at least change the function name to "copyVideoTextureToPlatformSubTexture"
and add a comment.

[dshwang, 2015/10/21 16:12:15]

This method is removed as unifying both into copyVideoTextureToPlatformTexture.
I comment "copying the whole video to a subregion of the target texture." in the
new struct.

+      blink::WebGraphicsContext3D* web_graphics_context,
+      unsigned int target,
+      unsigned int texture,
+      int level,
+      int xoffset,
+      int yoffset,
+      bool premultiply_alpha,
       bool flip_y) override;
 
   // True if the loaded media has a playable video/audio track.
   virtual bool hasVideo() const;
   virtual bool hasAudio() const;
 
   virtual bool isRemote() const;
 
   // Dimensions of the video.
   virtual blink::WebSize naturalSize() const;
@@ skipping 140 matching lines @@
   void DrawRemotePlaybackText(const std::string& remote_playback_message);
   void ReallocateVideoFrame();
   void SetCurrentFrameInternal(scoped_refptr<media::VideoFrame>& frame);
   void RemoveSurfaceTextureAndProxy();
   void DidLoadMediaInfo(MediaInfoLoader::Status status,
                         const GURL& redirected_url,
                         const GURL& first_party_for_cookies,
                         bool allow_stored_credentials);
   bool IsKeySystemSupported(const std::string& key_system);
   bool IsLocalResource();
+  bool CopyVideoTextureToPlatformTextureInternal(
+      blink::WebGraphicsContext3D* web_graphics_context,
+      bool is_full_copy,
+      unsigned int target,
+      unsigned int texture,
+      unsigned int internal_format,
+      unsigned int type,
+      int level,
+      int xoffset,
+      int yoffset,
+      bool premultiply_alpha,
+      bool flip_y);
 
   // Actually do the work for generateKeyRequest/addKey so they can easily
   // report results to UMA.
   MediaKeyException GenerateKeyRequestInternal(const std::string& key_system,
                                                const unsigned char* init_data,
                                                unsigned init_data_length);
   MediaKeyException AddKeyInternal(const std::string& key_system,
                                    const unsigned char* key,
                                    unsigned key_length,
                                    const unsigned char* init_data,
@@ skipping 216 matching lines @@
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_