Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: runtime/vm/service.cc

Issue 1315243002: Handle null isolate case in service tracing (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 3e9070ea40c691c0fcf4e66b47e702c41d209fbe..c7c8c5d68f49072046bda9372ce5dd62cb8690b4 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -737,10 +737,13 @@ void Service::PostEvent(const char* stream_id,
if (FLAG_trace_service) {
Isolate* isolate = Isolate::Current();
- ASSERT(isolate != NULL);
+ const char* isolate_name = "<no current isolate>";
+ if (isolate != NULL) {
+ isolate_name = isolate->name();
+ }
OS::Print(
"vm-service: Pushing event of type %s to stream %s (%s)\n",
- kind, stream_id, isolate->name());
+ kind, stream_id, isolate_name);
}
Dart_PostCObject(ServiceIsolate::Port(), &list_cobj);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698