Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1315233005: Revert "Reset the default browser choice on windows 10 on install" (Closed)

Created:
5 years, 3 months ago by grt (UTC plus 2)
Modified:
5 years, 3 months ago
Reviewers:
Patrick Monette
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Reset the default browser choice on windows 10 on install" This reverts commit 9ccf9d86e29f16aabdad65e13b09ac372355f18b. BUG=521191 TBR=pmonette@chromium.org Committed: https://crrev.com/a44a7d9ac39043f1ca1a83adeb125bb8d4cae638 Cr-Commit-Position: refs/heads/master@{#347806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M chrome/installer/setup/install.cc View 3 chunks +1 line, -24 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
grt (UTC plus 2)
Hi Patrick. PTAL. We decided to back this out for now. Thanks.
5 years, 3 months ago (2015-09-08 21:02:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315233005/1
5 years, 3 months ago (2015-09-08 21:11:17 UTC) #3
Patrick Monette
lgtm
5 years, 3 months ago (2015-09-08 21:13:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 21:48:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315233005/1
5 years, 3 months ago (2015-09-08 21:53:21 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-08 21:53:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315233005/1
5 years, 3 months ago (2015-09-08 21:57:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 22:03:39 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 22:04:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a44a7d9ac39043f1ca1a83adeb125bb8d4cae638
Cr-Commit-Position: refs/heads/master@{#347806}

Powered by Google App Engine
This is Rietveld 408576698