Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6178)

Unified Diff: Source/platform/graphics/paint/DisplayItemList.cpp

Issue 1315213002: (WIP) Paint invalidation for slimming paint v2 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/ViewPainter.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/DisplayItemList.cpp
diff --git a/Source/platform/graphics/paint/DisplayItemList.cpp b/Source/platform/graphics/paint/DisplayItemList.cpp
index 03b0ce50bbf8943f60766cdc54d5e63c4073bfba..9bc59d9234b9bf8eea9ed9d8629fbe39091859df 100644
--- a/Source/platform/graphics/paint/DisplayItemList.cpp
+++ b/Source/platform/graphics/paint/DisplayItemList.cpp
@@ -117,8 +117,9 @@ void DisplayItemList::endScope()
void DisplayItemList::invalidate(DisplayItemClient client)
{
ASSERT(RuntimeEnabledFeatures::slimmingPaintEnabled());
- // Can only be called during layout/paintInvalidation, not during painting.
- ASSERT(m_newDisplayItems.isEmpty());
+ // Paint invalidation may occur before or during painting. If the latter,
+ // we should not invalidate any client which has already has display items.
+ ASSERT(!m_newDisplayItemIndicesByClient.contains(client));
updateValidlyCachedClientsIfNeeded();
m_validlyCachedClients.remove(client);
updateSubtreeIndicesByClientIfNeeded();
« no previous file with comments | « Source/core/paint/ViewPainter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698