Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1315203002: Fix selection invalidation in composited scrollers. (Closed)

Created:
5 years, 3 months ago by chrishtr
Modified:
5 years, 3 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix selection invalidation in composited scrollers. The rects incorrectly included composited scroll offset. They should not, and instead follow the example set by https://codereview.chromium.org/1287413002. BUG=524547 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201287

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -13 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/paint/selection/selection-within-composited-scroller.html View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A + LayoutTests/paint/selection/selection-within-composited-scroller-expected.txt View 1 2 2 chunks +18 lines, -12 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
chrishtr
5 years, 3 months ago (2015-08-26 22:18:55 UTC) #2
Xianzhu
lgtm https://codereview.chromium.org/1315203002/diff/40001/LayoutTests/paint/selection/selection-within-composited-scroller.html File LayoutTests/paint/selection/selection-within-composited-scroller.html (right): https://codereview.chromium.org/1315203002/diff/40001/LayoutTests/paint/selection/selection-within-composited-scroller.html#newcode8 LayoutTests/paint/selection/selection-within-composited-scroller.html:8: scroller.scrollTop = 450; Extra space before '='. https://codereview.chromium.org/1315203002/diff/40001/LayoutTests/paint/selection/selection-within-composited-scroller.html#newcode14 ...
5 years, 3 months ago (2015-08-26 22:29:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315203002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315203002/60001
5 years, 3 months ago (2015-08-26 22:36:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/61214)
5 years, 3 months ago (2015-08-27 01:37:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315203002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315203002/60001
5 years, 3 months ago (2015-08-27 03:59:07 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201287
5 years, 3 months ago (2015-08-27 05:22:39 UTC) #11
chrishtr
5 years, 3 months ago (2015-08-28 20:16:43 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/1315203002/diff/40001/LayoutTests/paint/selec...
File LayoutTests/paint/selection/selection-within-composited-scroller.html
(right):

https://codereview.chromium.org/1315203002/diff/40001/LayoutTests/paint/selec...
LayoutTests/paint/selection/selection-within-composited-scroller.html:8:
scroller.scrollTop  = 450;
On 2015/08/26 at 22:29:44, Xianzhu wrote:
> Extra space before '='.

Fixed.

https://codereview.chromium.org/1315203002/diff/40001/LayoutTests/paint/selec...
LayoutTests/paint/selection/selection-within-composited-scroller.html:14: // Run
twice, because the first paint paints the whole screen regardless.
On 2015/08/26 at 22:29:44, Xianzhu wrote:
> What's this?

Removed, sorry.

Powered by Google App Engine
This is Rietveld 408576698