DevTools: allow blackboxing anonymous scripts

DevTools: allow blackboxing anonymous scripts

BUG=526239
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201661

[yurys, 2015-09-02 01:12:11]

yurys@chromium.org changed reviewers:
+ dgozman@chromium.org, kozyatinskiy@chromium.org, pfeldman@chromium.org

[yurys, 2015-09-02 01:12:20]

The CQ bit was checked by yurys@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-02 01:12:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315193014/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315193014/20001

[commit-bot: I haz the power, 2015-09-02 03:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 03:18:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yurys, 2015-09-02 17:08:01]

The CQ bit was checked by yurys@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-02 17:08:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315193014/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315193014/20001

[commit-bot: I haz the power, 2015-09-02 17:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 17:48:49]

Dry run: This issue passed the CQ dry run.

[dgozman, 2015-09-02 18:10:15]

I like the functionality. We can even make it default to blackbox our own eval'd
scripts. WDYT?

Should we add a test?

lgtm

[yurys, 2015-09-02 18:28:06]

On 2015/09/02 18:10:15, dgozman wrote:
> I like the functionality. We can even make it default to blackbox our own
eval'd
> scripts. WDYT?
> 
Hiding our own 'internal' scripts was going to be addressed separately.
@kozyatinsky should know better. We could start blackboxing all anonymous
scripts no only ours.

> Should we add a test?
> 
The test is already already there. Do you want to test something else in
particular?

> lgtm

[yurys, 2015-09-02 18:28:06]

On 2015/09/02 18:10:15, dgozman wrote:
> I like the functionality. We can even make it default to blackbox our own
eval'd
> scripts. WDYT?
> 
Hiding our own 'internal' scripts was going to be addressed separately.
@kozyatinsky should know better. We could start blackboxing all anonymous
scripts no only ours.

> Should we add a test?
> 
The test is already already there. Do you want to test something else in
particular?

> lgtm

[yurys, 2015-09-02 18:28:10]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2015-09-02 18:28:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315193014/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315193014/20001

[commit-bot: I haz the power, 2015-09-02 18:34:05]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201661