Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315193013: Enable drawBuffers() also on ES3 (Closed)

Created:
5 years, 3 months ago by Zhenyao Mo
Modified:
5 years, 3 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable drawBuffers() also on ES3 BUG=525930 TEST=conformance2/rendering/draw_buffers.html R=bajones@chromium.org,kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M Source/modules/webgl/WebGLFramebuffer.cpp View 1 chunk +19 lines, -18 lines 0 comments Download

Depends on Patchset:

Issue 1120953002 Patch 220001

Messages

Total messages: 9 (3 generated)
Zhenyao Mo
PTAL
5 years, 3 months ago (2015-09-01 20:45:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315193013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315193013/1
5 years, 3 months ago (2015-09-01 20:46:20 UTC) #3
Ken Russell (switch to Gerrit)
Excellent. LGTM
5 years, 3 months ago (2015-09-01 20:50:30 UTC) #4
bajones
lgtm
5 years, 3 months ago (2015-09-01 20:52:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315193013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315193013/1
5 years, 3 months ago (2015-09-01 22:03:41 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 23:26:54 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201585

Powered by Google App Engine
This is Rietveld 408576698