Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 1315193010: [crankshaft] Cleanup representation calculation for Phis. (Closed)

Created:
5 years, 3 months ago by Jarin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Cleanup representation calculation for Phis. This replaces the counters for use representations with simple tracking of most-general representation seen so far. R=bmeurer@chromium.org Committed: https://crrev.com/e0241e42ab9a9fb0a7c76fcb67b504e1916ce90b Cr-Commit-Position: refs/heads/master@{#30506}

Patch Set 1 #

Patch Set 2 : Remove useless TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -77 lines) Patch
M src/hydrogen-instructions.h View 1 3 chunks +18 lines, -36 lines 0 comments Download
M src/hydrogen-instructions.cc View 5 chunks +28 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 3 months ago (2015-09-01 10:47:06 UTC) #1
Benedikt Meurer
LGTM. Looks better indeed. But we should be careful not to fix too many issues ...
5 years, 3 months ago (2015-09-01 10:51:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315193010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315193010/20001
5 years, 3 months ago (2015-09-01 10:51:53 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 11:16:02 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 11:16:14 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0241e42ab9a9fb0a7c76fcb67b504e1916ce90b
Cr-Commit-Position: refs/heads/master@{#30506}

Powered by Google App Engine
This is Rietveld 408576698