Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1315183002: PPC: Fix "[turbofan] Support unboxed float and double stack parameters." (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix "[turbofan] Support unboxed float and double stack parameters." R=titzer@chromium.org, jyan@ca.ibm.com, dstence@us.ibm.com, joransiu@ca.ibm.com BUG= Committed: https://crrev.com/1fe4c1e7d655fc79b96fdbd28e80130f5ab8ce83 Cr-Commit-Position: refs/heads/master@{#30395}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 4 chunks +13 lines, -2 lines 1 comment Download
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-08-26 18:57:13 UTC) #1
titzer
https://codereview.chromium.org/1315183002/diff/1/src/compiler/ppc/code-generator-ppc.cc File src/compiler/ppc/code-generator-ppc.cc (right): https://codereview.chromium.org/1315183002/diff/1/src/compiler/ppc/code-generator-ppc.cc#newcode1348 src/compiler/ppc/code-generator-ppc.cc:1348: frame()->SetPCOnStack(false); You'll have to rebase this, since danno changed ...
5 years, 3 months ago (2015-08-26 19:18:37 UTC) #2
dstence
lgtm
5 years, 3 months ago (2015-08-26 19:20:18 UTC) #3
MTBrandyberry
On 2015/08/26 19:18:37, titzer wrote: > https://codereview.chromium.org/1315183002/diff/1/src/compiler/ppc/code-generator-ppc.cc > File src/compiler/ppc/code-generator-ppc.cc (right): > > https://codereview.chromium.org/1315183002/diff/1/src/compiler/ppc/code-generator-ppc.cc#newcode1348 > ...
5 years, 3 months ago (2015-08-26 19:21:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315183002/1
5 years, 3 months ago (2015-08-26 19:24:41 UTC) #6
titzer
On 2015/08/26 19:21:38, mtbrandyberry wrote: > On 2015/08/26 19:18:37, titzer wrote: > > > https://codereview.chromium.org/1315183002/diff/1/src/compiler/ppc/code-generator-ppc.cc ...
5 years, 3 months ago (2015-08-26 20:03:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 20:14:04 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 20:14:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fe4c1e7d655fc79b96fdbd28e80130f5ab8ce83
Cr-Commit-Position: refs/heads/master@{#30395}

Powered by Google App Engine
This is Rietveld 408576698