Signal error on send message failure.

ipc/ipc_channel_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_channel_posix.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <stddef.h>
 #include <sys/socket.h>
@@ skipping 454 matching lines @@
 
     if (bytes_written < 0 && !SocketWriteErrorIsRecoverable()) {
 #if defined(OS_MACOSX)
       // On OSX writing to a pipe with no listener returns EPERM.
       if (errno == EPERM) {
         Close();
         return false;
       }
 #endif  // OS_MACOSX
       if (errno == EPIPE) {
         Close();

[Fredrik Öhrn, 2014/01/29 10:41:00]

Yet another alternative is to change Close to ClosePipeOnError here.

Though that would mean ClosePipeOnError gets called twice in some cases, since
several existing code paths also call it when ProcessOutgoingMessages returns
false.

         return false;
       }
       PLOG(ERROR) << "pipe error on "
                   << fd_written
                   << " Currently writing message of size: "
                   << msg->size();
       return false;
     }
 
     if (static_cast<size_t>(bytes_written) != amt_to_write) {
@@ skipping 29 matching lines @@
            << " with type " << message->type()
            << " (" << output_queue_.size() << " in queue)";
 
 #ifdef IPC_MESSAGE_LOG_ENABLED
   Logging::GetInstance()->OnSendMessage(message, "");
 #endif  // IPC_MESSAGE_LOG_ENABLED
 
   message->TraceMessageBegin();
   output_queue_.push(message);
   if (!is_blocked_on_write_ && !waiting_connect_) {
-    return ProcessOutgoingMessages();
+    if (!ProcessOutgoingMessages()) {
+      ClosePipeOnError();
+      return false;
+    }
   }
 
   return true;
 }
 
 int Channel::ChannelImpl::GetClientFileDescriptor() {
   base::AutoLock lock(client_pipe_lock_);
   return client_pipe_;
 }
 
@@ skipping 565 matching lines @@
 
 
 #if defined(OS_LINUX)
 // static
 void Channel::SetGlobalPid(int pid) {
   ChannelImpl::SetGlobalPid(pid);
 }
 #endif  // OS_LINUX
 
 }  // namespace IPC