linux_aura: Use GTK button borders in GTK theme mode.

ui/views/controls/button/label_button.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_BUTTON_LABEL_BUTTON_H_
 #define UI_VIEWS_CONTROLS_BUTTON_LABEL_BUTTON_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/views/controls/button/custom_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/native_theme_delegate.h"
 
 namespace views {
 
+class LabelButtonBorder;
 class Painter;
 
 // LabelButton is an alternative to TextButton, it's not focusable by default.
 class VIEWS_EXPORT LabelButton : public CustomButton,
                                  public NativeThemeDelegate {
  public:
   // The length of the hover fade animation.
   static const int kHoverAnimationDurationMs;
 
   static const char kViewClassName[];
@@ skipping 59 matching lines @@
 
   // Fill |params| with information about the button.
   virtual void GetExtraParams(ui::NativeTheme::ExtraParams* params) const;
 
   // Resets colors from the NativeTheme, explicitly set colors are unchanged.
   virtual void ResetColorsFromNativeTheme();
 
   // Updates the image view to contain the appropriate button state image.
   void UpdateImage();
 
+  // Updates our border with a specific LabelButtonBorder instance which has
+  // different insets, etc. This may wrap the border in an object which will
+  // draw a native style border.
+  void UpdateThemedBorder(LabelButtonBorder* label_button_border);

[sky, 2014/01/22 20:23:59]

Can this take a scoped_ptr so ownership is clear?

[Elliot Glaysher, 2014/01/22 21:12:16]

If this takes a scoped_ptr<>, I then have to change every instance of Border in
chrome, since it is a wrapper around set_border(). Doing this cleanly would be
much larger than the rest of this patch. (I tried: I'm up to fifteen files so
far and I'm still getting massive spew.)

+
   // NativeThemeDelegate:
   virtual gfx::Rect GetThemePaintRect() const OVERRIDE;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(LabelButtonTest, Init);
   FRIEND_TEST_ALL_PREFIXES(LabelButtonTest, Label);
   FRIEND_TEST_ALL_PREFIXES(LabelButtonTest, Image);
   FRIEND_TEST_ALL_PREFIXES(LabelButtonTest, LabelAndImage);
   FRIEND_TEST_ALL_PREFIXES(LabelButtonTest, FontList);
 
@@ skipping 39 matching lines @@
   ButtonStyle style_;
 
   scoped_ptr<Painter> focus_painter_;
 
   DISALLOW_COPY_AND_ASSIGN(LabelButton);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_BUTTON_LABEL_BUTTON_H_