Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315123002: stray malloc/free -> sk_malloc/sk_free (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : duh, throw #

Patch Set 3 : realloc too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/core/SkRegion.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 2 8 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315123002/1
5 years, 3 months ago (2015-08-26 12:31:18 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/1187) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 3 months ago (2015-08-26 12:32:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315123002/20001
5 years, 3 months ago (2015-08-26 12:32:58 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315123002/40001
5 years, 3 months ago (2015-08-26 12:35:59 UTC) #8
mtklein_C
5 years, 3 months ago (2015-08-26 12:36:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315123002/40001
5 years, 3 months ago (2015-08-26 12:40:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315123002/40001
5 years, 3 months ago (2015-08-26 12:42:48 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/002c2ce66be69d41632c9603ce62c50f04156518
5 years, 3 months ago (2015-08-26 12:43:25 UTC) #17
bungeman-skia
5 years, 3 months ago (2015-08-26 14:52:11 UTC) #18
Message was sent while issue was closed. 
lgtm

As a side note, I did come across one not terrible reason to keep all the
allocation wrappers, which is to allow Skia, when build to be used exclusively
with a JVM, could be made to make all allocations using the JVM heap. Not that
it'll probably ever be a great idea, but I did come across something like this
recently.

Powered by Google App Engine
This is Rietveld 408576698