Implement a bluetooth picker dialog for Android

chrome/browser/android/chrome_web_contents_delegate_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_CHROME_WEB_CONTENTS_DELEGATE_ANDROID_H_
 #define CHROME_BROWSER_ANDROID_CHROME_WEB_CONTENTS_DELEGATE_ANDROID_H_
 
 #include <jni.h>
 
 #include "base/files/file_path.h"
 #include "components/web_contents_delegate_android/web_contents_delegate_android.h"
+#include "content/public/browser/bluetooth_chooser.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 
 class FindNotificationDetails;
 
 namespace content {
 struct FileChooserParams;
 class WebContents;
 }
 
@@ skipping 12 matching lines @@
     : public web_contents_delegate_android::WebContentsDelegateAndroid,
       public content::NotificationObserver {
  public:
   ChromeWebContentsDelegateAndroid(JNIEnv* env, jobject obj);
   ~ChromeWebContentsDelegateAndroid() override;
 
   void LoadingStateChanged(content::WebContents* source,
                            bool to_different_document) override;
   void RunFileChooser(content::WebContents* web_contents,
                       const content::FileChooserParams& params) override;
+  scoped_ptr<content::BluetoothChooser> RunBluetoothChooser(

[newt (away), 2015/09/01 21:51:23]

does this method belong in this class?

[Finnur, 2015/09/02 16:01:43]

I struggled with this quite a bit, and believe it belongs here.

content/browser/bluetooth/bluetooth_dispatcher_host.cc calls
WebContentsDelegate::RunBluetoothChooser, which is what I'm overriding here (in
chrome/browser/chrome_web_contents_delegate_android.h). This layer
(chrome/browser) is needed because my override function needs to instantiate
BluetoothChooserAndroid, which depends on chrome/browser.

If there's a better way, I'm willing to re-consider, but I bounced this off a
couple of people already and this was what was settled on.

[newt (away), 2015/09/02 17:48:42]

Ok, if you're overriding a method in web_contents_delegate.h, then this makes
sense. Thanks for explaining.

+      content::WebContents* web_contents,
+      const content::BluetoothChooser::EventHandler& event_handler,
+      const GURL& origin) override;
   void CloseContents(content::WebContents* web_contents) override;
   blink::WebDisplayMode GetDisplayMode(
       const content::WebContents* web_contents) const override;
   void FindReply(content::WebContents* web_contents,
                  int request_id,
                  int number_of_matches,
                  const gfx::Rect& selection_rect,
                  int active_match_ordinal,
                  bool final_update) override;
   void FindMatchRectsReply(content::WebContents* web_contents,
@@ skipping 37 matching lines @@
   content::NotificationRegistrar notification_registrar_;
 };
 
 // Register the native methods through JNI.
 bool RegisterChromeWebContentsDelegateAndroid(JNIEnv* env);
 
 }  // namespace android
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_ANDROID_CHROME_WEB_CONTENTS_DELEGATE_ANDROID_H_