Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 1315073002: Move global function isInline() to static function in IndentOutdentCommand.cpp (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move global function isInline() to static function in IndentOutdentCommand.cpp This patch moves global function |isInline()| defined in "EditingUtilities.{cpp,h}" to "IndentOutdentCommand.cpp" to reduce number of global functions for improving code health since |isInline()| is used only in "IndentOutdentCommand.cpp". BUG=n/a TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201216

Patch Set 1 : 2015-08-26T16:32:30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/core/editing/EditingUtilities.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-26 07:49:32 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-08-26 08:03:09 UTC) #3
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-26 08:05:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315073002/1
5 years, 3 months ago (2015-08-26 08:05:06 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 08:43:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201216

Powered by Google App Engine
This is Rietveld 408576698