Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Issue 1315063008: Sync: Remove NonBlockingDataTypeManager and any ProfileSyncService code related to it. (Closed)

Created:
5 years, 3 months ago by stanisc
Modified:
5 years, 3 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync: Remove NonBlockingDataTypeManager and any ProfileSyncService code related to it. This is cleanup of the code specific to NonBlockingDataTypeManager that shouldn't be needed anymore with the new implementation based on DataTypeManager shared between the regular datatypes and USS datatypes. Please note that there currently no unit tests for NonBlockingDataTypeManager and no tests for the methods removed from ProfileSyncService. There are unit tests for NonBlockingDataTypeController that use the class directly without the manager. NonBlockingDataTypeController remains unchanged for now. I'll change it in a separate change. BUG=515962 Committed: https://crrev.com/2bfaa40b7210df9f5e62cb1c572a772014992286 Cr-Commit-Position: refs/heads/master@{#348035}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -333 lines) Patch
M chrome/browser/sync/profile_sync_service.h View 7 chunks +6 lines, -44 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 24 chunks +53 lines, -133 lines 0 comments Download
M components/sync_driver.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/sync_driver/non_blocking_data_type_manager.h View 1 chunk +0 lines, -77 lines 0 comments Download
D components/sync_driver/non_blocking_data_type_manager.cc View 1 chunk +0 lines, -75 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
stanisc
Pavel, please take a look!
5 years, 3 months ago (2015-09-09 00:25:04 UTC) #3
pavely
lgtm
5 years, 3 months ago (2015-09-09 21:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315063008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315063008/20001
5 years, 3 months ago (2015-09-09 23:06:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-09-09 23:13:04 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2bfaa40b7210df9f5e62cb1c572a772014992286 Cr-Commit-Position: refs/heads/master@{#348035}
5 years, 3 months ago (2015-09-09 23:13:44 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:04:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bfaa40b7210df9f5e62cb1c572a772014992286
Cr-Commit-Position: refs/heads/master@{#348035}

Powered by Google App Engine
This is Rietveld 408576698