Remove obsolete DEBUG and NDEBUG macro dance.

Remove obsolete DEBUG and NDEBUG macro dance.

The original intention of this seemed to have been to enable DEBUG when
NDEBUG was not defined within Google3. Everything since then was just
added to avoid the "#error" below checking for consistency from firing.
Semantics have also shifted along the way. I vote for dropping this.

R=ulan@chromium.org

Committed: https://crrev.com/fe8cfe190e629d106b7a0db6f4f0f1730572dac9
Cr-Commit-Position: refs/heads/master@{#30591}

[ulan, 2015-09-04 14:01:35]

lgtm

[Michael Starzinger, 2015-09-04 14:02:29]

For posterity, the following is what this section looked like originally. The
intended semantics were different back then ...

+// Google3 uses NDEBUG.
+#if defined(GOOGLE3) && !defined(NDEBUG)
+#define DEBUG
+#endif
+
+// V8 only uses DEBUG, but included external files
+// may use NDEBUG - make sure they are consistent.
+#if defined(DEBUG) && defined(NDEBUG)
+#error both DEBUG and NDEBUG are set
+#endif

[Michael Starzinger, 2015-09-04 14:04:04]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-09-04 14:04:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315063007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315063007/1

[commit-bot: I haz the power, 2015-09-04 14:24:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-04 14:24:26]

Patchset 1 (id:??) landed as
https://crrev.com/fe8cfe190e629d106b7a0db6f4f0f1730572dac9
Cr-Commit-Position: refs/heads/master@{#30591}