Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 1315053003: gfx: Remove implicit conversions from gfx::Rect to gfx::RectF. (Closed)

Created:
5 years, 3 months ago by danakj
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman, vmpstr, Use pkasting(at)chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gfx: Remove implicit conversions from gfx::Rect to gfx::RectF. This removes the Rect::operator RectF(), and adds an explicit conversion constructor on RectF instead. R=sky@chromium.org BUG=342848 Committed: https://crrev.com/e6778ca2c41c723d518c31880b219db372257c42 Cr-Commit-Position: refs/heads/master@{#348767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M ui/gfx/geometry/rect.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/gfx/geometry/rect_f.h View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 43 (19 generated)
danakj
5 years, 3 months ago (2015-08-29 00:19:20 UTC) #1
sky
LGTM
5 years, 3 months ago (2015-08-29 16:06:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-08 18:38:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/51926) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-08 18:52:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-08 19:55:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/108786)
5 years, 3 months ago (2015-09-08 20:10:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-08 22:50:02 UTC) #12
danakj
(sorry for the noise.. fishing for any more implicit conversions until this can land)
5 years, 3 months ago (2015-09-08 22:50:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/130036) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-08 23:01:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-09 20:26:35 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/67266)
5 years, 3 months ago (2015-09-09 20:36:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-09 22:49:57 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/130526) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-09 23:01:44 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-11 18:00:22 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/53432)
5 years, 3 months ago (2015-09-11 18:13:20 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-11 19:32:26 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-11 21:39:20 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/131544) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-11 22:02:29 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-14 18:12:19 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/68886) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-14 18:37:54 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053003/1
5 years, 3 months ago (2015-09-14 20:36:10 UTC) #40
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 23:38:14 UTC) #41
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6778ca2c41c723d518c31880b219db372257c42 Cr-Commit-Position: refs/heads/master@{#348767}
5 years, 3 months ago (2015-09-14 23:38:54 UTC) #42
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:39:08 UTC) #43
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6778ca2c41c723d518c31880b219db372257c42
Cr-Commit-Position: refs/heads/master@{#348767}

Powered by Google App Engine
This is Rietveld 408576698