Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: Source/devtools/front_end/sdk/NetworkManager.js

Issue 1315043008: [DevTools] Show blocked requests in Network panel. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: hidden Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/Source/devtools/front_end/sdk/NetworkManager.js b/Source/devtools/front_end/sdk/NetworkManager.js
index 6b96b0d113aae028fab97cde727a11c0e423b624..05298ead376e825608fef49e7a3375ce2e11b05a 100644
--- a/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/Source/devtools/front_end/sdk/NetworkManager.js
@@ -429,9 +429,9 @@ WebInspector.NetworkDispatcher.prototype = {
* @param {!PageAgent.ResourceType} resourceType
* @param {string} localizedDescription
* @param {boolean=} canceled
- * @param {boolean=} blocked
+ * @param {!NetworkAgent.BlockedReason=} blockedReason
*/
- loadingFailed: function(requestId, time, resourceType, localizedDescription, canceled, blocked)
+ loadingFailed: function(requestId, time, resourceType, localizedDescription, canceled, blockedReason)
{
var networkRequest = this._inflightRequestsById[requestId];
if (!networkRequest)
@@ -440,7 +440,8 @@ WebInspector.NetworkDispatcher.prototype = {
networkRequest.failed = true;
networkRequest.setResourceType(WebInspector.resourceTypes[resourceType]);
networkRequest.canceled = canceled;
- networkRequest.blocked = blocked;
+ if (blockedReason)
+ networkRequest.setBlockedReason(blockedReason);
networkRequest.localizedFailDescription = localizedDescription;
this._finishNetworkRequest(networkRequest, time, -1);
},

Powered by Google App Engine
This is Rietveld 408576698