Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315043008: [DevTools] Show blocked requests in Network panel. (Closed)

Created:
5 years, 3 months ago by dgozman
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, Yoav Weiss, kinuko+watch, vivekg, gavinp+loader_chromium.org, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Show blocked requests in Network panel. BUG=468550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201747

Patch Set 1 #

Patch Set 2 : fprintf #

Patch Set 3 : hidden #

Total comments: 2

Patch Set 4 : simplified #

Patch Set 5 : includes #

Patch Set 6 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -43 lines) Patch
A LayoutTests/http/tests/inspector/network/network-blocked-reason.html View 1 chunk +75 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/inspector/network/network-blocked-reason-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 1 2 3 4 4 chunks +3 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 2 3 4 5 2 chunks +31 lines, -9 lines 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 2 3 4 5 7 chunks +29 lines, -16 lines 0 comments Download
M Source/devtools/front_end/network/BlockedURLsPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/NetworkDataGridNode.js View 1 2 3 4 5 2 chunks +21 lines, -3 lines 0 comments Download
M Source/devtools/front_end/network/NetworkLogView.js View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkManager.js View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkRequest.js View 1 2 3 4 5 2 chunks +18 lines, -5 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 3 4 5 2 chunks +8 lines, -1 line 0 comments Download
M Source/platform/network/ResourceRequest.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dgozman
Take a look please.
5 years, 3 months ago (2015-09-02 00:53:12 UTC) #2
pfeldman
https://codereview.chromium.org/1315043008/diff/40001/Source/core/loader/FrameFetchContext.cpp File Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/1315043008/diff/40001/Source/core/loader/FrameFetchContext.cpp#newcode350 Source/core/loader/FrameFetchContext.cpp:350: class BlockedRequestInspectorNotification { Why not return the enum?
5 years, 3 months ago (2015-09-02 02:49:21 UTC) #3
dgozman
PTAL https://codereview.chromium.org/1315043008/diff/40001/Source/core/loader/FrameFetchContext.cpp File Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/1315043008/diff/40001/Source/core/loader/FrameFetchContext.cpp#newcode350 Source/core/loader/FrameFetchContext.cpp:350: class BlockedRequestInspectorNotification { On 2015/09/02 02:49:21, pfeldman wrote: ...
5 years, 3 months ago (2015-09-02 22:59:57 UTC) #4
pfeldman
lgtm
5 years, 3 months ago (2015-09-03 17:25:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315043008/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315043008/80001
5 years, 3 months ago (2015-09-03 21:08:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/94043) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-03 21:10:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315043008/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315043008/100001
5 years, 3 months ago (2015-09-03 21:39:03 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 22:51:39 UTC) #13
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201747

Powered by Google App Engine
This is Rietveld 408576698