Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4665)

Unified Diff: chrome/browser/ui/views/apps/app_window_native_widget_mac.mm

Issue 1315043003: [MacViews] Position modal sheets using ModalDialogHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bbobserver
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_window_native_widget_mac.mm
diff --git a/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm b/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm
index 1bab9b8373373bc19105d504b911f2a1fee03e52..8c06a87326391e6dcb00744b7b5be6a6cdfdb9b9 100644
--- a/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm
+++ b/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm
@@ -20,6 +20,11 @@ AppWindowNativeWidgetMac::AppWindowNativeWidgetMac(
AppWindowNativeWidgetMac::~AppWindowNativeWidgetMac() {
}
+int AppWindowNativeWidgetMac::SheetPositionY() {
+ NSWindow* ns_window = GetNativeWindow();
+ return NSHeight([ns_window frame]) - NSMaxY([[ns_window contentView] frame]);
tapted 2015/08/26 03:20:41 how does this look for frameless widgets? (is it c
jackhou1 2015/08/26 07:02:08 I had tried this with the USB selector dialog, but
+}
+
NSWindow* AppWindowNativeWidgetMac::CreateNSWindow(
const views::Widget::InitParams& params) {
// If the window has a native or colored frame, use the same NSWindow as

Powered by Google App Engine
This is Rietveld 408576698