Issue 131503016: Properly trigger OnCanWrite processing from PacketDroppingTestWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131503016: Properly trigger OnCanWrite processing from PacketDroppingTestWriter. (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)

Modified:
6 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Properly trigger OnCanWrite processing from PacketDroppingTestWriter. Re-enable the LargePostWithPacketLossAndBlockedSocket test. Testing only. Dialing back the loss from 30% to 10% seems to have stabilized the test. Merge internal change: 60479729 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -21 lines)			Patch
M	net/tools/quic/end_to_end_test.cc	View	7 chunks	+36 lines, -12 lines	0 comments	Download
M	net/tools/quic/test_tools/packet_dropping_test_writer.h	View	3 chunks	+13 lines, -3 lines	0 comments	Download
M	net/tools/quic/test_tools/packet_dropping_test_writer.cc	View	5 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages