Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131503013: Added PrivetDeviceResolver to resolve a device and parse it as a privet device (Closed)

Created:
6 years, 10 months ago by Noam Samuel
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added PrivetDeviceResolver to resolve a device and parse it as a privet device Add a PrivetDeviceResolver that resolves a device and parses its TXT record based on the Privet protocol. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248583

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Patch
A chrome/browser/local_discovery/privet_device_resolver.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/privet_device_resolver.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Noam Samuel
6 years, 10 months ago (2014-01-28 19:43:33 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/131503013/diff/1/chrome/browser/local_discovery/privet_device_resolver.h File chrome/browser/local_discovery/privet_device_resolver.h (right): https://codereview.chromium.org/131503013/diff/1/chrome/browser/local_discovery/privet_device_resolver.h#newcode20 chrome/browser/local_discovery/privet_device_resolver.h:20: ResultCallback; missaligned https://codereview.chromium.org/131503013/diff/1/chrome/browser/local_discovery/privet_device_resolver.h#newcode23 chrome/browser/local_discovery/privet_device_resolver.h:23: ServiceDiscoveryClient* service_discovery_client, missaligned https://codereview.chromium.org/131503013/diff/1/chrome/browser/local_discovery/privet_device_resolver.h#newcode32 ...
6 years, 10 months ago (2014-01-29 23:13:16 UTC) #2
Noam Samuel
https://codereview.chromium.org/131503013/diff/1/chrome/browser/local_discovery/privet_device_resolver.h File chrome/browser/local_discovery/privet_device_resolver.h (right): https://codereview.chromium.org/131503013/diff/1/chrome/browser/local_discovery/privet_device_resolver.h#newcode20 chrome/browser/local_discovery/privet_device_resolver.h:20: ResultCallback; On 2014/01/29 23:13:16, Vitaly Buka wrote: > missaligned ...
6 years, 10 months ago (2014-01-29 23:22:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/131503013/40001
6 years, 10 months ago (2014-01-29 23:30:53 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253938
6 years, 10 months ago (2014-01-30 02:25:12 UTC) #5
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 10 months ago (2014-02-03 18:38:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/131503013/40001
6 years, 10 months ago (2014-02-03 18:40:04 UTC) #7
commit-bot: I haz the power
Change committed as 248583
6 years, 10 months ago (2014-02-03 22:02:23 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:02:28 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 22:02:35 UTC) #10
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698