Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1315023004: PlzNavigate: Add parameters to navigation structures for ServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: New parameters Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_request_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index 1180edfe940bf52a88826469ab34a45251f77988..3dbd9e766beed8a2fe01d0fc483cc758daaba974 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -89,7 +89,10 @@ scoped_ptr<NavigationRequest> NavigationRequest::CreateBrowserInitiated(
entry.ConstructCommonNavigationParams(dest_url, dest_referrer,
frame_entry, navigation_type),
BeginNavigationParams(method, headers.ToString(),
- LoadFlagFromNavigationType(navigation_type), false),
+ LoadFlagFromNavigationType(navigation_type),
+ false, // has_user_gestures
+ false, // skip_service_worker
+ REQUEST_CONTEXT_TYPE_HYPERLINK),
Fabrice (no longer in Chrome) 2015/10/06 12:09:58 nasko@ had a comment in the other about whether we
Fabrice (no longer in Chrome) 2015/10/06 13:40:56 We're currently using LOCATION, changing it.
entry.ConstructRequestNavigationParams(
frame_entry, navigation_start, is_same_document_history_load,
frame_tree_node->has_committed_real_load(),
@@ -116,9 +119,21 @@ scoped_ptr<NavigationRequest> NavigationRequest::CreateRendererInitiated(
// renderer and sent to the browser instead of being measured here.
// TODO(clamy): The pending history list offset should be properly set.
// TODO(clamy): Set has_committed_real_load.
- RequestNavigationParams request_params;
- request_params.current_history_list_offset = current_history_list_offset;
- request_params.current_history_list_length = current_history_list_length;
+ RequestNavigationParams request_params(
+ false, // is_overriding_user_agent
+ base::TimeTicks::Now(), // browser_navigation_start
+ std::vector<GURL>(), // redirects
+ false, // can_load_local_resources
+ base::Time::Now(), // request_time
+ PageState(), // page_state
+ -1, // page_id
+ 0, // nav_entry_id
+ false, // is_same_document_history_load
+ false, // has_committed_real_load
+ false, // intended_as_new_entry
+ -1, // pending_history_list_offset
+ current_history_list_offset, current_history_list_length,
+ false); // should_clear_history_list
scoped_ptr<NavigationRequest> navigation_request(
new NavigationRequest(frame_tree_node, common_params, begin_params,
request_params, body, false, nullptr, nullptr));
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_request_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698