Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: chrome/browser/ui/browser.cc

Issue 13150004: Support color chooser inside extesions, apps, chrome frame, dev tool (Closed) Base URL: http://git.chromium.org/chromium/src.git@ngcolor
Patch Set: Used static class member Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 47f07ca08101b70370974018ae0223815784857b..dcae920ea9b6287c44461f3529b191502eaf91a4 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -108,6 +108,7 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/chrome_select_file_policy.h"
+#include "chrome/browser/ui/color_chooser.h"
#include "chrome/browser/ui/extensions/shell_window.h"
#include "chrome/browser/ui/find_bar/find_bar.h"
#include "chrome/browser/ui/find_bar/find_bar_controller.h"
@@ -150,7 +151,6 @@
#include "chrome/common/search_types.h"
#include "chrome/common/startup_metric_utils.h"
#include "chrome/common/web_apps.h"
-#include "content/public/browser/color_chooser.h"
#include "content/public/browser/devtools_manager.h"
#include "content/public/browser/download_item.h"
#include "content/public/browser/download_manager.h"
@@ -1513,27 +1513,8 @@ content::JavaScriptDialogManager* Browser::GetJavaScriptDialogManager() {
}
content::ColorChooser* Browser::OpenColorChooser(WebContents* web_contents,
- int color_chooser_id,
- SkColor color) {
-#if defined(OS_WIN)
- // On Windows, only create a color chooser if one doesn't exist, because we
- // can't close the old color chooser dialog.
- if (!color_chooser_.get())
- color_chooser_.reset(content::ColorChooser::Create(color_chooser_id,
- web_contents,
- color));
-#else
- if (color_chooser_.get())
- color_chooser_->End();
- color_chooser_.reset(content::ColorChooser::Create(color_chooser_id,
- web_contents,
- color));
-#endif
- return color_chooser_.get();
-}
-
-void Browser::DidEndColorChooser() {
- color_chooser_.reset();
+ SkColor initial_color) {
+ return ColorChooser::Open(web_contents, initial_color);
}
void Browser::RunFileChooser(WebContents* web_contents,

Powered by Google App Engine
This is Rietveld 408576698