Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1314973004: Add test-run-native-calls tests for mixed parameters. (Closed)

Created:
5 years, 3 months ago by titzer
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add test-run-native-calls tests for mixed parameters. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/43389ce7310878f93aefe459180f1e85f56e90e2 Cr-Commit-Position: refs/heads/master@{#30448}

Patch Set 1 #

Patch Set 2 : Fix type punning with memcpy. #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -0 lines) Patch
M test/cctest/compiler/test-run-native-calls.cc View 1 2 3 1 chunk +128 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 3 months ago (2015-08-28 11:07:28 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
5 years, 3 months ago (2015-08-28 15:20:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314973004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314973004/60001
5 years, 3 months ago (2015-08-28 15:21:10 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-08-28 15:30:10 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 15:30:28 UTC) #6
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/43389ce7310878f93aefe459180f1e85f56e90e2
Cr-Commit-Position: refs/heads/master@{#30448}

Powered by Google App Engine
This is Rietveld 408576698