chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc - Issue 1314953009: Refactor WebsiteSettings to operate on a SecurityInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc

Issue 1314953009: Refactor WebsiteSettings to operate on a SecurityInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_context_menu/render_view_context_menu.cc ('K') | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('j') | chrome/browser/ui/website_settings/website_settings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc

diff --git a/chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc b/chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc

index 8e1a860c9e57ec92d4ad66f47f0890dc5d79e0aa..2c2dc2a19788128198a1f3a1bb09c8088ee3b872 100644

--- a/chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc

+++ b/chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc

@@ -90,6 +90,10 @@ void WebAppLeftHeaderView::ShowWebsiteSettings() const {

if (!nav_entry)

return;

+ SecurityStateModel* security_model = SecurityStateModel::FromWebContents(tab);

+ DCHECK(security_model);

chrome::ShowWebsiteSettings(browser_view_->browser(), tab,

- nav_entry->GetURL(), nav_entry->GetSSL());

+ nav_entry->GetURL(),

+ security_model->GetSecurityInfo());

}