Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314953002: Rename ViewManagerService,ViewManagerClient -> ViewTree,ViewTreeClient (Closed)

Created:
5 years, 4 months ago by Ben Goodger (Google)
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ViewManagerService,ViewManagerClient -> ViewTree,ViewTreeClient Updates associated impls & client lib objects. R=sky@chromium.org BUG=none Committed: https://crrev.com/ba49abb6a34b20de2da47f71b784407184ce236d Cr-Commit-Position: refs/heads/master@{#345448}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+645 lines, -4962 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_document_oopif.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_document_oopif.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M components/view_manager/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M components/view_manager/access_policy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/client_connection.h View 2 chunks +14 lines, -14 lines 0 comments Download
M components/view_manager/client_connection.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/view_manager/connection_manager.h View 7 chunks +22 lines, -23 lines 0 comments Download
M components/view_manager/connection_manager.cc View 15 chunks +23 lines, -25 lines 0 comments Download
M components/view_manager/connection_manager_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/view_manager/display_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/display_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/ids.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/public/cpp/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/public/cpp/lib/view.cc View 14 chunks +21 lines, -23 lines 0 comments Download
D components/view_manager/public/cpp/lib/view_manager_client_impl.h View 1 chunk +0 lines, -159 lines 0 comments Download
D components/view_manager/public/cpp/lib/view_manager_client_impl.cc View 1 chunk +0 lines, -450 lines 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_init.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + components/view_manager/public/cpp/lib/view_tree_client_impl.h View 5 chunks +15 lines, -16 lines 0 comments Download
A + components/view_manager/public/cpp/lib/view_tree_client_impl.cc View 17 chunks +101 lines, -101 lines 0 comments Download
M components/view_manager/public/cpp/tests/view_manager_test_base.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/view_manager/public/cpp/tests/view_manager_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/view_manager/public/cpp/view.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/view_manager/public/cpp/view_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/view_manager/public/cpp/view_manager_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/view_manager/public/cpp/view_manager_init.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/view_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D components/view_manager/public/interfaces/view_manager.mojom View 1 chunk +0 lines, -247 lines 0 comments Download
A + components/view_manager/public/interfaces/view_tree.mojom View 5 chunks +15 lines, -16 lines 0 comments Download
M components/view_manager/server_view.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/test_change_tracker.h View 4 chunks +6 lines, -6 lines 0 comments Download
M components/view_manager/view_manager_app.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/view_manager/view_manager_app.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M components/view_manager/view_manager_client_apptest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M components/view_manager/view_manager_root_connection.h View 5 chunks +7 lines, -7 lines 0 comments Download
M components/view_manager/view_manager_root_connection.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/view_manager/view_manager_root_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/view_manager/view_manager_root_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/view_manager/view_manager_root_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D components/view_manager/view_manager_service_apptest.cc View 1 chunk +0 lines, -1763 lines 0 comments Download
D components/view_manager/view_manager_service_impl.h View 1 chunk +0 lines, -275 lines 0 comments Download
D components/view_manager/view_manager_service_impl.cc View 1 chunk +0 lines, -787 lines 0 comments Download
D components/view_manager/view_manager_service_unittest.cc View 1 chunk +0 lines, -612 lines 0 comments Download
A + components/view_manager/view_tree_apptest.cc View 64 chunks +107 lines, -110 lines 0 comments Download
A + components/view_manager/view_tree_impl.h View 11 chunks +26 lines, -29 lines 0 comments Download
A + components/view_manager/view_tree_impl.cc View 50 chunks +87 lines, -95 lines 0 comments Download
A + components/view_manager/view_tree_unittest.cc View 21 chunks +50 lines, -50 lines 0 comments Download
M mandoline/tab/frame.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/tab/frame.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mandoline/tab/frame_apptest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M mandoline/tab/frame_connection.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/tab/frame_connection.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/tab/frame_tree_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/tab/public/cpp/web_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mandoline/tab/public/interfaces/web_view.mojom View 2 chunks +3 lines, -3 lines 0 comments Download
M mandoline/tab/test_frame_tree_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/tab/test_frame_tree_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/tab/web_view_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mandoline/tab/web_view_impl.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ben Goodger (Google)
5 years, 4 months ago (2015-08-25 21:22:42 UTC) #1
sky
I looked at the interesting bits, LGTM
5 years, 4 months ago (2015-08-25 21:44:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314953002/20001
5 years, 4 months ago (2015-08-25 21:48:24 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-25 21:54:27 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 21:55:11 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ba49abb6a34b20de2da47f71b784407184ce236d
Cr-Commit-Position: refs/heads/master@{#345448}

Powered by Google App Engine
This is Rietveld 408576698