Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 131493005: [Ozone] Removing Stub SFO implementation & CreateTestHelper from SFO (Closed)

Created:
6 years, 11 months ago by dnicoara
Modified:
6 years, 11 months ago
Reviewers:
rjkroege, sadrul
CC:
chromium-reviews, rjkroege, sadrul, ben+aura_chromium.org, ozone-reviews_chromium.org, kalyank
Visibility:
Public.

Description

[Ozone] Removing Stub SFO implementation & CreateTestHelper from SFO Given we now use the OzonePlatform to initialize SFO and we already have a test implementation(the file backend), the Stub implementation isn't required. After the removal the unittests will default to using the file backend. This change also fixes the recent brakage of aura_unittests since the Stub SFO returns 0 (kNullAcceleratedWidget) for a widget, which triggers a DCHECK failure in WindowTreeHost::DestroyCompositor. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -52 lines) Patch
M ui/aura/test/aura_test_helper.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/gfx/ozone/surface_factory_ozone.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/ozone/surface_factory_ozone.cc View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dnicoara
PTAL
6 years, 11 months ago (2014-01-16 16:23:07 UTC) #1
rjkroege
lgtm
6 years, 11 months ago (2014-01-16 17:46:15 UTC) #2
sadrul
lgtm
6 years, 11 months ago (2014-01-16 17:47:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/131493005/1
6 years, 11 months ago (2014-01-16 19:36:58 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247563
6 years, 11 months ago (2014-01-16 21:36:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/131493005/1
6 years, 11 months ago (2014-01-16 22:06:08 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 23:44:11 UTC) #7
Message was sent while issue was closed.
Change committed as 245377

Powered by Google App Engine
This is Rietveld 408576698