Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1314913009: [Android] Move some pylib modules into devil/ (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
aiolos (Not reviewing), chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, nednguyen, ghost stip (do not use), sullivan, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Move some pylib modules into devil/ BUG=476719 TBR=maruel@chromium.org Committed: https://crrev.com/bb6ecf6b1c2f7e879db2213b0fcb494fba559110 Cr-Commit-Position: refs/heads/master@{#346806}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : TELEMETRY_DEPS #

Total comments: 4

Patch Set 5 : perezju comments #

Patch Set 6 : content/telemetry.isolate #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -10214 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +4 lines, -4 lines 0 comments Download
A + build/android/devil/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + build/android/devil/android/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/android/apk_helper.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + build/android/devil/android/battery_utils.py View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
A + build/android/devil/android/battery_utils_test.py View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
A + build/android/devil/android/decorators.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + build/android/devil/android/decorators_test.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + build/android/devil/android/device_blacklist.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/android/device_errors.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + build/android/devil/android/device_list.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/android/device_signal.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/android/device_temp_file.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + build/android/devil/android/device_temp_file_test.py View 1 chunk +4 lines, -4 lines 0 comments Download
A + build/android/devil/android/device_utils.py View 1 2 3 4 1 chunk +18 lines, -18 lines 0 comments Download
A + build/android/devil/android/device_utils_device_test.py View 1 chunk +4 lines, -4 lines 0 comments Download
A + build/android/devil/android/device_utils_test.py View 1 20 chunks +43 lines, -34 lines 0 comments Download
A + build/android/devil/android/logcat_monitor.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + build/android/devil/android/logcat_monitor_test.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + build/android/devil/android/md5sum.py View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A + build/android/devil/android/md5sum_test.py View 1 2 3 4 4 chunks +9 lines, -6 lines 0 comments Download
A + build/android/devil/android/sdk/__init__.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + build/android/devil/android/sdk/aapt.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + build/android/devil/android/sdk/adb_wrapper.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + build/android/devil/android/sdk/adb_wrapper_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + build/android/devil/android/sdk/dexdump.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + build/android/devil/android/sdk/intent.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/android/sdk/keyevent.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/android/sdk/shared_prefs.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/android/sdk/shared_prefs_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + build/android/devil/android/sdk/split_select.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + build/android/devil/base_error.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/utils/cmd_helper.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/utils/cmd_helper_test.py View 1 chunk +1 line, -1 line 0 comments Download
A + build/android/devil/utils/host_utils.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/utils/mock_calls.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/utils/mock_calls_test.py View 1 chunk +1 line, -1 line 0 comments Download
A + build/android/devil/utils/parallelizer.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + build/android/devil/utils/parallelizer_test.py View 1 chunk +1 line, -1 line 0 comments Download
A + build/android/devil/utils/reraiser_thread.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/devil/utils/reset_usb.py View 1 chunk +4 lines, -4 lines 0 comments Download
A + build/android/devil/utils/run_tests_helper.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/utils/timeout_retry.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + build/android/devil/utils/watchdog_timer.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/devil/utils/zip_utils.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D build/android/pylib/cmd_helper.py View 1 1 chunk +4 lines, -286 lines 0 comments Download
D build/android/pylib/cmd_helper_test.py View 1 chunk +0 lines, -83 lines 0 comments Download
M build/android/pylib/constants/__init__.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
D build/android/pylib/constants/keyevent.py View 1 chunk +0 lines, -14 lines 0 comments Download
D build/android/pylib/device/adb_wrapper.py View 1 1 chunk +4 lines, -645 lines 0 comments Download
D build/android/pylib/device/adb_wrapper_test.py View 1 chunk +0 lines, -96 lines 0 comments Download
M build/android/pylib/device/battery_utils.py View 1 2 3 4 5 6 1 chunk +3 lines, -630 lines 0 comments Download
D build/android/pylib/device/battery_utils_test.py View 1 2 3 4 5 6 1 chunk +0 lines, -647 lines 0 comments Download
D build/android/pylib/device/decorators.py View 1 1 chunk +4 lines, -141 lines 0 comments Download
D build/android/pylib/device/decorators_test.py View 1 chunk +0 lines, -288 lines 0 comments Download
D build/android/pylib/device/device_blacklist.py View 1 1 chunk +4 lines, -78 lines 0 comments Download
D build/android/pylib/device/device_errors.py View 1 1 chunk +4 lines, -85 lines 0 comments Download
D build/android/pylib/device/device_list.py View 1 1 chunk +4 lines, -26 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 3 4 1 chunk +4 lines, -1921 lines 0 comments Download
D build/android/pylib/device/device_utils_device_test.py View 1 chunk +0 lines, -220 lines 0 comments Download
D build/android/pylib/device/device_utils_test.py View 1 1 chunk +0 lines, -1998 lines 0 comments Download
D build/android/pylib/device/intent.py View 1 1 chunk +4 lines, -109 lines 0 comments Download
D build/android/pylib/device/logcat_monitor.py View 1 1 chunk +3 lines, -134 lines 0 comments Download
D build/android/pylib/device/logcat_monitor_test.py View 1 chunk +0 lines, -164 lines 0 comments Download
D build/android/pylib/device/shared_prefs.py View 1 1 chunk +3 lines, -386 lines 0 comments Download
D build/android/pylib/device/shared_prefs_test.py View 1 chunk +0 lines, -169 lines 0 comments Download
D build/android/pylib/device_signal.py View 1 1 chunk +3 lines, -36 lines 0 comments Download
M build/android/pylib/flag_changer.py View 1 chunk +0 lines, -2 lines 0 comments Download
D build/android/pylib/sdk/aapt.py View 1 1 chunk +3 lines, -37 lines 0 comments Download
D build/android/pylib/sdk/dexdump.py View 1 1 chunk +3 lines, -25 lines 0 comments Download
D build/android/pylib/sdk/split_select.py View 1 1 chunk +3 lines, -53 lines 0 comments Download
D build/android/pylib/utils/apk_helper.py View 1 1 chunk +4 lines, -127 lines 0 comments Download
D build/android/pylib/utils/base_error.py View 1 1 chunk +3 lines, -11 lines 0 comments Download
D build/android/pylib/utils/device_temp_file.py View 1 1 chunk +4 lines, -59 lines 0 comments Download
D build/android/pylib/utils/device_temp_file_test.py View 1 chunk +0 lines, -91 lines 0 comments Download
D build/android/pylib/utils/host_utils.py View 1 1 chunk +4 lines, -12 lines 0 comments Download
M build/android/pylib/utils/md5sum.py View 1 2 3 4 1 chunk +4 lines, -111 lines 0 comments Download
D build/android/pylib/utils/md5sum_test.py View 1 2 3 4 1 chunk +0 lines, -231 lines 0 comments Download
D build/android/pylib/utils/mock_calls.py View 1 1 chunk +4 lines, -178 lines 0 comments Download
D build/android/pylib/utils/mock_calls_test.py View 1 chunk +0 lines, -175 lines 0 comments Download
D build/android/pylib/utils/parallelizer.py View 1 1 chunk +4 lines, -238 lines 0 comments Download
D build/android/pylib/utils/parallelizer_test.py View 1 chunk +0 lines, -166 lines 0 comments Download
D build/android/pylib/utils/reraiser_thread.py View 1 1 chunk +4 lines, -154 lines 0 comments Download
D build/android/pylib/utils/run_tests_helper.py View 1 1 chunk +4 lines, -40 lines 0 comments Download
D build/android/pylib/utils/timeout_retry.py View 1 1 chunk +4 lines, -163 lines 0 comments Download
D build/android/pylib/utils/watchdog_timer.py View 1 1 chunk +4 lines, -43 lines 0 comments Download
D build/android/pylib/utils/zip_utils.py View 1 1 chunk +3 lines, -26 lines 0 comments Download
M content/telemetry.isolate View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/TELEMETRY_DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
jbudorick
5 years, 3 months ago (2015-08-28 18:47:12 UTC) #2
rnephew (Reviews Here)
On 2015/08/28 18:47:12, jbudorick wrote: lgtm. Maybe we should add some logging to the build/android/pylib ...
5 years, 3 months ago (2015-08-28 18:58:06 UTC) #3
mikecase (-- gone --)
lgtm
5 years, 3 months ago (2015-08-28 19:11:41 UTC) #4
jbudorick
On 2015/08/28 at 18:58:06, rnephew wrote: > On 2015/08/28 18:47:12, jbudorick wrote: > > lgtm. ...
5 years, 3 months ago (2015-08-28 19:11:55 UTC) #5
nednguyen
lgtm
5 years, 3 months ago (2015-08-31 20:34:56 UTC) #7
jbudorick
+stip: fyi
5 years, 3 months ago (2015-09-01 00:11:12 UTC) #8
perezju
sweet! lgtm, just a couple of comments https://codereview.chromium.org/1314913009/diff/60001/build/android/devil/android/sdk/__init__.py File build/android/devil/android/sdk/__init__.py (right): https://codereview.chromium.org/1314913009/diff/60001/build/android/devil/android/sdk/__init__.py#newcode3 build/android/devil/android/sdk/__init__.py:3: # found ...
5 years, 3 months ago (2015-09-01 08:12:52 UTC) #9
jbudorick
https://codereview.chromium.org/1314913009/diff/60001/build/android/devil/android/sdk/__init__.py File build/android/devil/android/sdk/__init__.py (right): https://codereview.chromium.org/1314913009/diff/60001/build/android/devil/android/sdk/__init__.py#newcode3 build/android/devil/android/sdk/__init__.py:3: # found in the LICENSE file. On 2015/09/01 at ...
5 years, 3 months ago (2015-09-01 22:14:56 UTC) #10
jbudorick
TBR maruel for content/telemetry.isolate, since some of build/android/pylib/ is moving into build/android/devil/
5 years, 3 months ago (2015-09-02 00:26:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314913009/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314913009/120001
5 years, 3 months ago (2015-09-02 00:26:16 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 3 months ago (2015-09-02 01:00:39 UTC) #16
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/bb6ecf6b1c2f7e879db2213b0fcb494fba559110 Cr-Commit-Position: refs/heads/master@{#346806}
5 years, 3 months ago (2015-09-02 01:01:15 UTC) #17
M-A Ruel
5 years, 3 months ago (2015-09-02 01:25:37 UTC) #18
Message was sent while issue was closed.
On 2015/09/02 00:26:04, jbudorick wrote:
> TBR maruel for content/telemetry.isolate, since some of build/android/pylib/
is
> moving into build/android/devil/

I love the name, lgtm

Powered by Google App Engine
This is Rietveld 408576698