Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/scheduler/child/scheduler_helper_unittest.cc

Issue 1314903007: Implement WebFrameScheduler and WebPageScheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added some tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/scheduler/child/scheduler_helper.cc ('K') | « components/scheduler/child/scheduler_helper.cc ('k') | components/scheduler/child/task_queue.h » ('j') | components/scheduler/child/task_queue_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/child/scheduler_helper_unittest.cc
diff --git a/components/scheduler/child/scheduler_helper_unittest.cc b/components/scheduler/child/scheduler_helper_unittest.cc
index 2807186a853e3aa176fca7a4c5004b2c02cc19e4..8283d5de1ec810c6df91646fe94d4af71f6963ea 100644
--- a/components/scheduler/child/scheduler_helper_unittest.cc
+++ b/components/scheduler/child/scheduler_helper_unittest.cc
@@ -183,4 +183,21 @@ TEST_F(SchedulerHelperTest,
RunUntilIdle();
}
+namespace {
+class MockObserver : public SchedulerHelper::Observer {
+ public:
+ MOCK_METHOD1(OnUnregisterTaskQueue,
+ void(const scoped_refptr<TaskQueue>& queue));
+};
+} // namespace
+
+TEST_F(SchedulerHelperTest, OnUnregisterTaskQueue) {
+ MockObserver observer;
Sami 2015/09/10 15:10:23 Hmm, how does this work -- shouldn't the observer
alex clarke (OOO till 29th) 2015/09/10 15:56:24 Yeah that was just completely broken :(
+ scoped_refptr<TaskQueue> task_queue =
+ scheduler_helper_->NewTaskQueue(TaskQueue::Spec("test_queue"));
+
+ task_queue->UnregisterTaskQueue();
+ EXPECT_CALL(observer, OnUnregisterTaskQueue(_)).Times(0);
+}
+
} // namespace scheduler
« components/scheduler/child/scheduler_helper.cc ('K') | « components/scheduler/child/scheduler_helper.cc ('k') | components/scheduler/child/task_queue.h » ('j') | components/scheduler/child/task_queue_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698