components/sync_driver/proxy_data_type_controller.h - Issue 1314903004: Sync: Refactoring DataTypeController to make the design shareable with USS datatypes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/proxy_data_type_controller.h

Issue 1314903004: Sync: Refactoring DataTypeController to make the design shareable with USS datatypes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/non_ui_data_type_controller_unittest.cc ('k') | components/sync_driver/proxy_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/proxy_data_type_controller.h

diff --git a/components/sync_driver/proxy_data_type_controller.h b/components/sync_driver/proxy_data_type_controller.h

index 97a49e5302bd25699fb801cb30f5aa36192ce62f..8aaa9026a6164134ed14011768b4133073aeba26 100644

--- a/components/sync_driver/proxy_data_type_controller.h

+++ b/components/sync_driver/proxy_data_type_controller.h

@@ -18,7 +18,7 @@ namespace sync_driver {

class ProxyDataTypeController : public DataTypeController {

public:

explicit ProxyDataTypeController(

- scoped_refptr<base::SingleThreadTaskRunner> ui_thread,

+ const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,

syncer::ModelType type);

// DataTypeController interface.

@@ -26,10 +26,10 @@ class ProxyDataTypeController : public DataTypeController {

void StartAssociating(const StartCallback& start_callback) override;

void Stop() override;

syncer::ModelType type() const override;

- syncer::ModelSafeGroup model_safe_group() const override;

- ChangeProcessor* GetChangeProcessor() const override;

std::string name() const override;

State state() const override;

+ void ActivateDataType(BackendDataTypeConfigurer* configurer) override;

+ void DeactivateDataType(BackendDataTypeConfigurer* configurer) override;

// DataTypeErrorHandler interface.

void OnSingleDataTypeUnrecoverableError(